You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Check consistency between merge target and title. #111
python/cpython#7765
is a trivial doc change intended for master, 3.7, 3.6, and 2.7. I reviewed,
approved, marked labels, and after a 2nd approval, merged it. miss-islington
cherry-picked it to 3.7, but failed for 3.6 and 2.7. The author then discovered
that the 3.6 failure was because the original PR was (accidentally) against
3.6, not master.
On core_mentorship, Nick suggested that the best way to catch such an error is for Bedevere to check consistency between between branch merge target (in above case, 3.6) and the presence or absence of a branch label (in above case, none).
"When bedevere checks for the BPO issue reference, it could also check
that the target branch matches the commit message prefix (i.e. if
there's no "[3.6] " at the start, then targetting the 3.6 branch is
wrong - PRs without a version prefix should always be targeting
master, and PRs deliberately targeting a maintenance branch directly
should include the prefix).
"
Possible message:
"If this PR is really for 3.6, prefix [3.6] to the title.
If this PR is for master, CLOSE IT and make a new PR."
Activity
Mariatta commentedon Jun 24, 2018
Duplicate of python/core-workflow#211
Post a status check for backport PR title.
Post a status check for backport PR title.
Post a status check for backport PR title. (#112)