Skip to content

Commit ae95190

Browse files
RonnyPfannschmidtClaude Opus 5
andcommitted
test: do not run the xmlsec download regression test on python 3.8
pip has no lxml wheel for cpython 3.8, so it falls back to the lxml sdist; --no-build-isolation then leaves that build without a toolchain and metadata preparation fails before xmlsec is ever built. The regression this test guards is unrelated to that, so mark it xfail with run=False on 3.8 instead of letting the missing toolchain fail CI. Verified locally: XFAIL [NOTRUN] on 3.8, runs and passes on 3.9 and 3.13. Co-Authored-By: Claude Opus 5 <ai@anthropic.com> Co-Authored-By: Claude Code <ai@anthropic.com>
1 parent 2822b07 commit ae95190

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Do not run the xmlsec download regression test on Python 3.8, where no lxml wheel exists and `--no-build-isolation` leaves pip without a build toolchain for the lxml sdist.

‎setuptools-scm/testing_scm/test_integration.py‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -726,6 +726,12 @@ def test_integration_function_call_order(
726726
@pytest.mark.skipif(
727727
sys.implementation.name == "pypy", reason="xmlsec build fails on PyPy in CI"
728728
)
729+
@pytest.mark.xfail(
730+
sys.version_info < (3, 9),
731+
reason="no lxml wheel for cpython 3.8, so pip builds lxml from source and"
732+
" --no-build-isolation leaves it without a build toolchain",
733+
run=False,
734+
)
729735
def test_xmlsec_download_regression(
730736
tmp_path: Path, monkeypatch: pytest.MonkeyPatch
731737
) -> None:

0 commit comments

Comments
 (0)