Repository navigation
Commit 244b250
committed
fix: always use copies for the isolated venv on Windows (#1176)
The broken probe fixed in #1118 (1.6.0, broken previously) wasn't
actually supposed to be there; `python -m venv` doesn't check for
symlink support. Even if symlinks are supported, python don't always
work symlinked on Windows. This PR removes the check.
Fixes #1175.
:robot: _AI text below_ :robot:
Version 1.6.0 fixed the symlink probe in #1118. Before that fix the
probe always failed on Windows, so every isolated environment was built
from copies. After the fix, GitHub Windows runners report symlink
support, and `venv` started to symlink `python.exe`. A symlinked
interpreter cannot find the DLLs of some Python builds, most visibly
conda, and pip fails with `DLL load failed while importing _ssl` /
`_ctypes`. Projects such as xgboost, LightGBM, and partcad have pinned
`build<1.6` to work around this.
This change removes the probe and hardcodes `symlinks=os.name != 'nt'`,
which is the `venv` CLI default and the behavior all releases before
1.6.0 had in practice. The two tests for the probe are removed with it.1 parent c93ca6f commit 244b250
3 files changed
Lines changed: 6 additions & 76 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
67 | 70 | | |
68 | 71 | | |
69 | 72 | | |
| |||
359 | 362 | | |
360 | 363 | | |
361 | 364 | | |
362 | | - | |
| 365 | + | |
363 | 366 | | |
364 | 367 | | |
365 | 368 | | |
| |||
459 | 462 | | |
460 | 463 | | |
461 | 464 | | |
462 | | - | |
| 465 | + | |
463 | 466 | | |
464 | 467 | | |
465 | 468 | | |
| |||
497 | 500 | | |
498 | 501 | | |
499 | 502 | | |
500 | | - | |
501 | | - | |
502 | | - | |
503 | | - | |
504 | | - | |
505 | | - | |
506 | | - | |
507 | | - | |
508 | | - | |
509 | | - | |
510 | | - | |
511 | | - | |
512 | | - | |
513 | | - | |
514 | | - | |
515 | | - | |
516 | | - | |
517 | | - | |
518 | 503 | | |
519 | 504 | | |
520 | 505 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
271 | 215 | | |
272 | 216 | | |
273 | 217 | | |
| |||
0 commit comments