why do Getter results live in Eff? #11

Activity

1. matthewleon

   added a commit that references this issue on Oct 29, 2017

   Remove effect from Getter

   ...

   4b6e080
2. jacereda commented on Oct 29, 2017

   

   jacereda

   on Oct 29, 2017

   Collaborator

   More actions

   I'm not sure about this. Could the compiler, in a case like this:

   DV.setUint8 dv 0 123
   let a = DV.getUint8 dv 0
   DV.setUint8 dv 0 456
   let b = DV.getUint8 dv 0
   

   be free to reorder the getters in a way that yields unexpected results for that code?
3. matthewleon commented on Oct 30, 2017

   

   matthewleon

   on Oct 30, 2017

   Author

   More actions

   Ah I see. I think the issue here might be that what these Effs are doing is ST type stuff.

   I'm working on a fork of this where I adopt the approach used here: https://pursuit.purescript.org/packages/purescript-arrays/4.0.1/docs/Data.Array.ST

   I think that might be fruitful.
4. matthewleon

   closed this as completedon Oct 30, 2017
5. jacereda commented on Oct 30, 2017

   

   jacereda

   on Oct 30, 2017

   Collaborator

   More actions

   Great, freeze/thaw seems the way to go.
6. matthewleon commented on Nov 13, 2017

   

   matthewleon

   on Nov 13, 2017

   Author

   More actions

   Implementing the ST approach here: https://github.com/matthewleon/purescript-arraybuffer-safe