remove isNode check from getReadableFromProtocolStream and other similar usages

as the PR is now landed: nodejs/node#39062 (nodejs/node#39062 (comment))

Lines 345 to 353 in 5b792de

    
           async function getReadableFromProtocolStream( 
        
             client: CDPSession, 
        
             handle: string 
        
           ): Promise<Readable> { 
        
             // TODO: 
        
             // This restriction can be lifted once https://github.com/nodejs/node/pull/39062 has landed 
        
             if (!isNode) { 
        
               throw new Error('Cannot create a stream outside of Node.js environment.'); 
        
             }

We're marking this issue as unconfirmed because it has not had recent activity and we weren't able to confirm it yet. It will be closed if no further activity occurs within the next 30 days.

I believe this has happened.

Navigation Menu

Repository navigation

remove `isNode` check from `getReadableFromProtocolStream` and other similar usages #7861

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	async function getReadableFromProtocolStream(
	client: CDPSession,
	handle: string
	): Promise<Readable> {
	// TODO:
	// This restriction can be lifted once https://github.com/nodejs/node/pull/39062 has landed
	if (!isNode) {
	throw new Error('Cannot create a stream outside of Node.js environment.');
	}

remove isNode check from getReadableFromProtocolStream and other similar usages #7861

Description

Activity

stale commented on Aug 6, 2022

OrKoN commented on Mar 23, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

remove `isNode` check from `getReadableFromProtocolStream` and other similar usages #7861