command: go install fails with: error obtaining VCS status: exit status 128 while installing check #2722

Activity

1. asottile commented on Jan 25, 2023

   

   asottile

   on Jan 25, 2023

   Member

   More actions

   it works fine for me in both 2.21 and 3.0 -- do you have any other GO environment variables or other things interfering?
2. pestanko commented on Jan 26, 2023

   

   pestanko

   on Jan 26, 2023

   Author

   More actions

   I am not sure what the cause might be.

   One thing I have noticed is when I was doing interactive rebase with renaming commit, the pre-commit check installation/initialization succeeded - what comes to my mind - maybe some timeouts?

   ❯ git rebase -i origin/master
   [INFO] Installing environment for https://github.com/stackrox/kube-linter.
   [INFO] Once installed this environment will be reused.
   [INFO] This may take a few minutes...
   [INFO] Installing environment for https://github.com/adrienverge/yamllint.git.
   [INFO] Once installed this environment will be reused.
   [INFO] This may take a few minutes...
   [INFO] Installing environment for https://github.com/Yelp/detect-secrets.
   [INFO] Once installed this environment will be reused.
   [INFO] This may take a few minutes...
   check for added large files..........................(no files to check)Skipped
   check for merge conflicts............................(no files to check)Skipped
   detect aws credentials...............................(no files to check)Skipped
   detect private key...................................(no files to check)Skipped
   fix end of files.....................................(no files to check)Skipped
   mixed line ending....................................(no files to check)Skipped
   trim trailing whitespace.............................(no files to check)Skipped
   KubeLinter...........................................(no files to check)Skipped
   yamllint.............................................(no files to check)Skipped
   Detect secrets.......................................(no files to check)Skipped
   [detached HEAD 57ca14ed] stuff
    Date: Thu Jan 26 09:48:21 2023 +0100
    5 files changed, 67 insertions(+), 12 deletions(-)
   Successfully rebased and updated refs/heads/feat/stuff.
   

   Additional information:

   Git version: 2.39.1

   This is my go env

   $ go env
   
   GO111MODULE=""
   GOARCH="arm64"
   GOBIN=""
   GOCACHE="/Users/.../Library/Caches/go-build"
   GOENV="/Users/.../Library/Application Support/go/env"
   GOEXE=""
   GOEXPERIMENT=""
   GOFLAGS=""
   GOHOSTARCH="arm64"
   GOHOSTOS="darwin"
   GOINSECURE=""
   GOMODCACHE="/Users/.../go/pkg/mod"
   GONOPROXY=""
   GONOSUMDB=""
   GOOS="darwin"
   GOPATH="/Users/.../go"
   GOPRIVATE=""
   GOPROXY="https://proxy.golang.org,direct"
   GOROOT="/opt/homebrew/Cellar/go/1.19.5/libexec"
   GOSUMDB="sum.golang.org"
   GOTMPDIR=""
   GOTOOLDIR="/opt/homebrew/Cellar/go/1.19.5/libexec/pkg/tool/darwin_arm64"
   GOVCS=""
   GOVERSION="go1.19.5"
   GCCGO="gccgo"
   AR="ar"
   CC="clang"
   CXX="clang++"
   CGO_ENABLED="1"
   GOMOD="/dev/null"
   GOWORK=""
   CGO_CFLAGS="-g -O2"
   CGO_CPPFLAGS=""
   CGO_CXXFLAGS="-g -O2"
   CGO_FFLAGS="-g -O2"
   CGO_LDFLAGS="-g -O2"
   PKG_CONFIG="pkg-config"
   GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/jh/6dnhwcxn5m592yf4_l1nkr_r0000gn/T/go-build2822682343=/tmp/go-build -gno-record-gcc-switches -fno-common"
3. asottile commented on Jan 26, 2023

   

   asottile

   on Jan 26, 2023

   Member

   More actions

   my guess is the error was needing to upgrade macos CLT or whatever. either way it's working now
4. asottile

   closed this as completedon Jan 26, 2023
5. zedtux commented on Feb 15, 2023

   

   zedtux

   on Feb 15, 2023

   More actions

   I'm facing this error right now on my Linux box while it works perfectly on my macOS box.

   Traceback (most recent call last):
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/error_handler.py", line 73, in error_handler
       yield
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/main.py", line 366, in main
       return hook_impl(
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/commands/hook_impl.py", line 254, in hook_impl
       return retv | run(config, store, ns)
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/commands/run.py", line 437, in run
       install_hook_envs(to_install, store)
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/repository.py", line 239, in install_hook_envs
       _hook_install(hook)
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/repository.py", line 86, in _hook_install
       lang.install_environment(
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/languages/golang.py", line 152, in install_environment
       helpers.run_setup_cmd(prefix, ('go', 'install', './...'), env=env)
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/languages/helpers.py", line 49, in run_setup_cmd
       cmd_output_b(*cmd, cwd=prefix.prefix_dir, **kwargs)
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/util.py", line 115, in cmd_output_b
       raise CalledProcessError(returncode, cmd, stdout_b, stderr_b)
   pre_commit.util.CalledProcessError: command: ('/home/zedtux/.cache/pre-commit/repo56ywbt73/golangenv-default/.go/bin/go', 'install', './...')
   return code: 1
   stdout: (none)
   stderr:
       go: downloading github.com/rs/zerolog v1.26.1
       ...
           go: downloading golang.org/x/text v0.3.6
       go: downloading github.com/mattn/go-isatty v0.0.14
       error obtaining VCS status: exit status 128
       	Use -buildvcs=false to disable VCS stamping.
       error obtaining VCS status: exit status 128
       	Use -buildvcs=false to disable VCS stamping.
   

   I'm running Elementary OS 6 (Ubuntu Focal like) and I did install it using pip.
6. asottile commented on Feb 15, 2023

   

   asottile

   on Feb 15, 2023

   Member

   More actions

   can you share the same information as above? -- generally this failure isn't a pre-commit problem and is instead a misconfiguration of go
7. zedtux commented on Feb 15, 2023

   

   zedtux

   on Feb 15, 2023

   More actions

   Sure, here it is :

   Additional information:

   Git version: 2.25.1

   go env fails for me as it is not installed!
8. asottile commented on Feb 15, 2023

   

   asottile

   on Feb 15, 2023

   Member

   More actions

   yeah I need your config and everything else too
9. zedtux commented on Feb 15, 2023

   

   zedtux

   on Feb 15, 2023

   More actions

   Oops, sorry :

   pre-commit --version

   pre-commit 3.0.4

   .pre-commit-config.yaml

   repos:
   - repo: https://github.com/antonbabenko/pre-commit-terraform
     rev: v1.77.1 # Get the latest from: https://github.com/antonbabenko/pre-commit-terraform/releases
     hooks:
       - id: terraform_fmt
       - id: terraform_docs
       - id: terraform_tfsec
       - id: terraform_validate
   - repo: https://github.com/zricethezav/gitleaks
     rev: v8.15.3
     hooks:
       - id: gitleaks

   ~/.cache/pre-commit/pre-commit.log if present

   version information

   pre-commit version: 3.0.4
   git --version: git version 2.25.1
   sys.version:
       3.8.10 (default, Nov 14 2022, 12:59:47) 
       [GCC 9.4.0]
   sys.executable: /usr/bin/python3
   os.name: posix
   sys.platform: linux
   

   error information

   An unexpected error has occurred: CalledProcessError: command: ('/home/zedtux/.cache/pre-commit/repo56ywbt73/golangenv-default/.go/bin/go', 'install', './...')
   return code: 1
   stdout: (none)
   stderr:
       go: downloading github.com/rs/zerolog v1.26.1
       go: downloading github.com/lucasjones/reggen v0.0.0-20200904144131-37ba4fa293bb
       go: downloading github.com/gitleaks/go-gitdiff v0.8.0
       go: downloading github.com/spf13/viper v1.8.1
       go: downloading github.com/spf13/cobra v1.2.1
       go: downloading github.com/charmbracelet/lipgloss v0.5.0
       go: downloading github.com/petar-dambovaliev/aho-corasick v0.0.0-20211021192214-5ab2d9280aa9
       go: downloading github.com/fatih/semgroup v1.2.0
       go: downloading github.com/h2non/filetype v1.1.3
       go: downloading github.com/spf13/pflag v1.0.5
       go: downloading golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
       go: downloading github.com/muesli/reflow v0.2.1-0.20210115123740-9e1d0d53df68
       go: downloading github.com/lucasb-eyer/go-colorful v1.2.0
       go: downloading github.com/mattn/go-runewidth v0.0.13
       go: downloading github.com/muesli/termenv v0.11.1-0.20220204035834-5ac8409525e0
       go: downloading github.com/fsnotify/fsnotify v1.4.9
       go: downloading github.com/hashicorp/hcl v1.0.0
       go: downloading github.com/magiconair/properties v1.8.5
       go: downloading github.com/mitchellh/mapstructure v1.4.1
       go: downloading github.com/pelletier/go-toml v1.9.3
       go: downloading github.com/spf13/afero v1.6.0
       go: downloading github.com/spf13/cast v1.3.1
       go: downloading github.com/spf13/jwalterweatherman v1.1.0
       go: downloading github.com/subosito/gotenv v1.2.0
       go: downloading gopkg.in/ini.v1 v1.62.0
       go: downloading gopkg.in/yaml.v2 v2.4.0
       go: downloading github.com/rivo/uniseg v0.2.0
       go: downloading golang.org/x/sys v0.0.0-20211110154304-99a53858aa08
       go: downloading golang.org/x/text v0.3.6
       go: downloading github.com/mattn/go-isatty v0.0.14
       error obtaining VCS status: exit status 128
       	Use -buildvcs=false to disable VCS stamping.
       error obtaining VCS status: exit status 128
       	Use -buildvcs=false to disable VCS stamping.
       
   

   Traceback (most recent call last):
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/error_handler.py", line 73, in error_handler
       yield
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/main.py", line 366, in main
       return hook_impl(
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/commands/hook_impl.py", line 254, in hook_impl
       return retv | run(config, store, ns)
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/commands/run.py", line 437, in run
       install_hook_envs(to_install, store)
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/repository.py", line 239, in install_hook_envs
       _hook_install(hook)
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/repository.py", line 86, in _hook_install
       lang.install_environment(
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/languages/golang.py", line 152, in install_environment
       helpers.run_setup_cmd(prefix, ('go', 'install', './...'), env=env)
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/languages/helpers.py", line 49, in run_setup_cmd
       cmd_output_b(*cmd, cwd=prefix.prefix_dir, **kwargs)
     File "/usr/local/lib/python3.8/dist-packages/pre_commit/util.py", line 115, in cmd_output_b
       raise CalledProcessError(returncode, cmd, stdout_b, stderr_b)
   pre_commit.util.CalledProcessError: command: ('/home/zedtux/.cache/pre-commit/repo56ywbt73/golangenv-default/.go/bin/go', 'install', './...')
   return code: 1
   stdout: (none)
   stderr:
       go: downloading github.com/rs/zerolog v1.26.1
       go: downloading github.com/lucasjones/reggen v0.0.0-20200904144131-37ba4fa293bb
       go: downloading github.com/gitleaks/go-gitdiff v0.8.0
       go: downloading github.com/spf13/viper v1.8.1
       go: downloading github.com/spf13/cobra v1.2.1
       go: downloading github.com/charmbracelet/lipgloss v0.5.0
       go: downloading github.com/petar-dambovaliev/aho-corasick v0.0.0-20211021192214-5ab2d9280aa9
       go: downloading github.com/fatih/semgroup v1.2.0
       go: downloading github.com/h2non/filetype v1.1.3
       go: downloading github.com/spf13/pflag v1.0.5
       go: downloading golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
       go: downloading github.com/muesli/reflow v0.2.1-0.20210115123740-9e1d0d53df68
       go: downloading github.com/lucasb-eyer/go-colorful v1.2.0
       go: downloading github.com/mattn/go-runewidth v0.0.13
       go: downloading github.com/muesli/termenv v0.11.1-0.20220204035834-5ac8409525e0
       go: downloading github.com/fsnotify/fsnotify v1.4.9
       go: downloading github.com/hashicorp/hcl v1.0.0
       go: downloading github.com/magiconair/properties v1.8.5
       go: downloading github.com/mitchellh/mapstructure v1.4.1
       go: downloading github.com/pelletier/go-toml v1.9.3
       go: downloading github.com/spf13/afero v1.6.0
       go: downloading github.com/spf13/cast v1.3.1
       go: downloading github.com/spf13/jwalterweatherman v1.1.0
       go: downloading github.com/subosito/gotenv v1.2.0
       go: downloading gopkg.in/ini.v1 v1.62.0
       go: downloading gopkg.in/yaml.v2 v2.4.0
       go: downloading github.com/rivo/uniseg v0.2.0
       go: downloading golang.org/x/sys v0.0.0-20211110154304-99a53858aa08
       go: downloading golang.org/x/text v0.3.6
       go: downloading github.com/mattn/go-isatty v0.0.14
       error obtaining VCS status: exit status 128
       	Use -buildvcs=false to disable VCS stamping.
       error obtaining VCS status: exit status 128
       	Use -buildvcs=false to disable VCS stamping.
   
10. asottile commented on Feb 15, 2023

    

    asottile

    on Feb 15, 2023

    Last edited by asottile

    Member

    More actions

    can you share env | grep -Ei '(GIT|PRE_COMMIT|GO)' | sort, your ~/.gitconfig and ls -al ~/.cache/pre-commit ?
11. zedtux commented on Feb 15, 2023

    

    zedtux

    on Feb 15, 2023

    More actions

    env | grep -Ei '(GIT|PRE_COMMIT|GO)' | sort

    $ env | grep -Ei '(GIT|PRE_COMMIT|GO)' | sort
    TF_VAR_OAUTH2_PASS=[redacted]
    

    ~/.gitconfig

     [user]
    	name = Guillaume Hain
    	email = zedtux@zedroot.org
    	signingkey = BC63F4AEB4B5092E3104C289D2B2A8B99474CF36
    
    [color]
    	branch = auto
    	status = auto
    	diff = auto
    	ui = always
    
    [alias]
    	st = "!git_stash_check; rails_project_cleaner.sh; git status -sb"
    	ci = commit
    	co = checkout
    	restore = checkout HEAD --
    	uncommit = reset --soft HEAD^
    	l = log --decorate --show-signature
    	lg = log --decorate --graph --show-signature
            master = checkout master
            develop = checkout develop
            staging = checkout staging
    	cir = "!git_make_a_new_release"
    	branches = branch -a
            spull = submodule foreach git pull
    	changedfiles = "!git diff --name-only $GIT_DEFAULT_BRANCH `git rev-parse --abbrev-ref HEAD`"
            rmbranches = "!git branch --merged ${GIT_DEFAULT_BRANCH:-master} | grep -v ${GIT_DEFAULT_BRANCH:-master} | xargs git branch -D"
    	refreshbranches = remote update origin --prune
    [push]
    	default = tracking
    	followTags = true
    
    [status]
    	showUntrackedFiles = all
    
    [pack]
    	threads = 2
    
    [core]
    	editor = nano
    	quotepath = false
    [mergetool]
    	keepBackup = false
    	prompt = false
    [branch]
    	autosetupmerge = true
    [filter "media"]
    	clean = git-media-clean %f
    	smudge = git-media-smudge %f
    [difftool]
    	prompt = false
    [commit]
    	gpgsign = true
    [filter "lfs"]
    	clean = git-lfs clean %f
    	smudge = git-lfs smudge %f
    	required = true
    [merge]
    	tool = meld
    [gpg]
    	program = gpg
    [merge "ours"]
    	driver = true
    

    ls -al ~/.cache/pre-commit

    ls -al ~/.cache/pre-commit
    total 48
    drwxrwxr-x  4 zedtux zedtux  4096 Feb 15 21:11 .
    drwxr-xr-x 26 zedtux zedtux  4096 Feb 15 21:28 ..
    drwx------ 10 zedtux zedtux  4096 Feb 15 21:18 repo56ywbt73
    drwx------  8 zedtux zedtux  4096 Feb 15 21:10 repovpqakma5
    -rw-------  1 zedtux zedtux 20480 Feb 15 21:10 db.db
    -rw-rw-r--  1 zedtux zedtux     0 Feb 15 21:10 .lock
    -rw-rw-r--  1 zedtux zedtux  5917 Feb 15 21:18 pre-commit.log
    -rw-rw-r--  1 zedtux zedtux   109 Feb 15 21:10 README
    
12. asottile commented on Feb 16, 2023

    

    asottile

    on Feb 16, 2023

    Member

    More actions

    tried reproducing in docker and didn't really get anywhere -- any chance you could strace and see what git command go is running and why it fails?
13. awartoft commented on Mar 13, 2023

    

    awartoft

    on Mar 13, 2023

    More actions

    I'm getting this on MacOS so I can't use strace for me is failing on the same package just a slightly different version.

        go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
        error obtaining VCS status: exit status 128
        	Use -buildvcs=false to disable VCS stamping.
        error obtaining VCS status: exit status 128
        	Use -buildvcs=false to disable VCS stamping.
        error obtaining VCS status: exit status 128
        	Use -buildvcs=false to disable VCS stamping.
        error obtaining VCS status: exit status 128
        	Use -buildvcs=false to disable VCS stamping.
    
14. colindean commented on Apr 3, 2023

    

    colindean

    on Apr 3, 2023

    More actions

    I'm encountering this now.

    Workaround

    I'm able to circumvent this problem by committing once like so:

    GOFLAGS=-buildvcs=false git commit -av
    

    After this succeeded, if I run pre-commit clean && pre-commit install-hooks, I don't see the error again. I'd expect to see it, so I might be doing something odd here. I expected to have to do

    GOFLAGS=-buildvcs=false pre-commit install-hooks
    

    after pre-commit clean.

    Research and observations

    Some research indicates that it's related to one or more of the following:

    • go 1.18 embeds git information at build time
    • The build directory needing to be in git's safe.directory

    Possible remedies

    1. Do what it says on the tin: add -buildvcs=false here, perhaps with end-user control of it
    2. Maybe the there needs to be a go get && git config --global --add safe.directory ${where_go_get_put_it} && go install ${where_go_get_put_it}; I'm not a Go dev so 🤷

    See also:

    • cmd/go: VCS stamping complains inappropriately about VCS in unreleated parent directory golang/go#49004
    • error obtaining VCS status: exit status 128 microsoft/azurelinux#3273
    • https://www.reddit.com/r/golang/comments/x5e3ld/how_to_set_buildvcsfalse_as_default/

    Requested troubleshooting information

    version information

    pre-commit version: 3.2.1
    git --version: git version 2.40.0
    sys.version:
        3.11.2 (main, Feb 16 2023, 02:55:59) [Clang 14.0.0 (clang-1400.0.29.202)]
    sys.executable: /opt/homebrew/Cellar/pre-commit/3.2.1/libexec/bin/python3
    os.name: posix
    sys.platform: darwin
    

    error information

    An unexpected error has occurred: CalledProcessError: command: ('/opt/homebrew/bin/go', 'install', './...')
    return code: 1
    stdout: (none)
    stderr:
        error obtaining VCS status: exit status 128
        	Use -buildvcs=false to disable VCS stamping.
        error obtaining VCS status: exit status 128
        	Use -buildvcs=false to disable VCS stamping.
    

    Traceback (most recent call last):
      File "/opt/homebrew/Cellar/pre-commit/3.2.1/libexec/lib/python3.11/site-packages/pre_commit/error_handler.py", line 73, in error_handler
        yield
      File "/opt/homebrew/Cellar/pre-commit/3.2.1/libexec/lib/python3.11/site-packages/pre_commit/main.py", line 381, in main
        return hook_impl(
               ^^^^^^^^^^
      File "/opt/homebrew/Cellar/pre-commit/3.2.1/libexec/lib/python3.11/site-packages/pre_commit/commands/hook_impl.py", line 271, in hook_impl
        return retv | run(config, store, ns)
                      ^^^^^^^^^^^^^^^^^^^^^^
      File "/opt/homebrew/Cellar/pre-commit/3.2.1/libexec/lib/python3.11/site-packages/pre_commit/commands/run.py", line 442, in run
        install_hook_envs(to_install, store)
      File "/opt/homebrew/Cellar/pre-commit/3.2.1/libexec/lib/python3.11/site-packages/pre_commit/repository.py", line 248, in install_hook_envs
        _hook_install(hook)
      File "/opt/homebrew/Cellar/pre-commit/3.2.1/libexec/lib/python3.11/site-packages/pre_commit/repository.py", line 95, in _hook_install
        lang.install_environment(
      File "/opt/homebrew/Cellar/pre-commit/3.2.1/libexec/lib/python3.11/site-packages/pre_commit/languages/golang.py", line 152, in install_environment
        lang_base.setup_cmd(prefix, ('go', 'install', './...'), env=env)
      File "/opt/homebrew/Cellar/pre-commit/3.2.1/libexec/lib/python3.11/site-packages/pre_commit/lang_base.py", line 87, in setup_cmd
        cmd_output_b(*cmd, cwd=prefix.prefix_dir, **kwargs)
      File "/opt/homebrew/Cellar/pre-commit/3.2.1/libexec/lib/python3.11/site-packages/pre_commit/util.py", line 110, in cmd_output_b
        raise CalledProcessError(returncode, cmd, stdout_b, stderr_b)
    pre_commit.util.CalledProcessError: command: ('/opt/homebrew/bin/go', 'install', './...')
    return code: 1
    stdout: (none)
    stderr:
        error obtaining VCS status: exit status 128
        	Use -buildvcs=false to disable VCS stamping.
        error obtaining VCS status: exit status 128
        	Use -buildvcs=false to disable VCS stamping.
    

    env | grep -Ei '(GIT|PRE_COMMIT|GO)' | sort

    FZF_CTRL_T_COMMAND=rg --files --no-ignore --hidden --follow -g "!{.git,node_modules,build}/*" 2> /dev/null
    FZF_DEFAULT_COMMAND=rg --files --no-ignore --hidden --follow -g "!{.git,node_modules,build}/*" 2> /dev/null
    GIT_PS1_SHOWDIRTYSTATE=true
    GIT_PS1_SHOWUNTRACKEDFILES=true
    GOPATH=/Users/colin/.go
    PATH=/Users/colin/.conscript/bin:/Users/colin/.cache/micromamba/condabin:/Users/colin/.pyenv/shims:/Users/colin/.local/bin:/Users/colin/.bin:/opt/homebrew/opt/curl/bin:/opt/homebrew/opt/llvm/bin:/Library/Java/Home/bin:/Users/colin/.cargo/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin:/Library/TeX/texbin:/Library/Application Support/CDM/bin:/usr/local/munki:/Applications/kitty.app/Contents/MacOS:/usr/local/opt/rust/bin:/Users/colin/.cabal/bin:/usr/local/heroku/bin:/usr/local/opt/go/libexec/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin:/Library/TeX/texbin:/Library/Application Support/CDM/bin:/usr/local/munki:/Applications/kitty.app/Contents/MacOS
    PS1=\[\e]133;k;start_kitty\a\]\[\e]133;A\a\]\[\e]133;k;end_kitty\a\]\[\033[1;37m\][\[\033[1;33m\]\t \[\033[0;32m\]\u@\H \[\033[0;36m\]\w \[\033[1;37m\]]\n\[\e]133;k;start_secondary_kitty\a\]\[\e]133;A;k=s\a\]\[\e]133;k;end_secondary_kitty\a\]\[\033[1;31m\]$(if [ ! -z "`command -v __git_ps1`" ]; then _GITPS1="`__git_ps1`"; if [ ! -z "${_GITPS1}" ]; then echo -n "±${_GITPS1}"; echo -n ' '; fi; fi)\[\033[0;37m\]$(if [ $SHLVL -gt 1 ]; then echo "⇟$SHLVL"; fi)$ \[\e]133;k;start_suffix_kitty\a\]\[\e[5 q\]\[\e]2;\w\a\]\[\e]133;k;end_suffix_kitty\a\]
    __CFBundleIdentifier=net.kovidgoyal.kitty
    

    ls -al ~/.cache/pre-commit

    $ ls -al ~/.cache/pre-commit
    total 56
    drwxr-xr-x@  9 colin  staff    288 Apr  3 14:46 .
    drwxr-xr-x   9 colin  staff    288 Apr  3 14:46 ..
    -rw-r--r--@  1 colin  staff      0 Apr  3 14:46 .lock
    -rw-r--r--@  1 colin  staff    109 Apr  3 14:46 README
    -rw-------@  1 colin  staff  20480 Apr  3 14:46 db.db
    -rw-r--r--@  1 colin  staff   2676 Apr  3 14:46 pre-commit.log
    drwx------@ 30 colin  staff    960 Apr  3 14:46 repofs85lks_
    drwx------@  9 colin  staff    288 Apr  3 14:46 repogmqgmb7n
    drwx------@ 20 colin  staff    640 Apr  3 14:46 reporuqzcd7b
    

    .pre-commit-config.yaml

    $ cat .pre-commit-config.yaml
    # See https://pre-commit.com for more information
    # See https://pre-commit.com/hooks.html for more hooks
    repos:
      -   repo: https://github.com/pre-commit/pre-commit-hooks
          rev: v4.2.0
          hooks:
            - id: trailing-whitespace
            - id: end-of-file-fixer
            - id: check-yaml
            - id: check-json
            - id: check-added-large-files
            - id: check-case-conflict
            - id: check-executables-have-shebangs
            - id: check-shebang-scripts-are-executable
            - id: check-symlinks
            - id: check-merge-conflict
            - id: destroyed-symlinks
            - id: check-toml
    
      - repo: https://github.com/comkieffer/pre-commit-xmllint.git
        rev: 1.0.0
        hooks:
          - id: xmllint
    
      # keep Makefile tidy and neat
      -   repo: https://github.com/mrtazz/checkmake.git
          # check this for updates once in a while, look for tags
          rev: 4e37f3a6ea00208b3f5bd04eaa0f075068237f18
          hooks:
            -   id: checkmake
    

    ❤️React with ❤️14Reacted by awartoft, Daniel Graña, Peter Stanko, Jeff Fairchild, Vladimir Rusinov, Marcin Owsiany, Xavier Wang, Steven Lam, Ali Tavafi, Matt Braymer-Hayes and 4 more
15. colindean

    added a commit that references this issue on Apr 3, 2023

    Adds a system-provided checkmake hook for pre-commit

    ...

    0212f16
16. colindean

    added 2 commits that reference this issue on Apr 13, 2023

    Adds precommit config

    ...

    4cde380

    Use local checkmake since pre-commit doesn't compile the go right

    ...

    c0af8b7
17. colindean commented on Apr 13, 2023

    

    colindean

    on Apr 13, 2023

    Last edited by colindean

    More actions

    I'm encountering this on Linux, too.

    $ git commit -av
    [INFO] Initializing environment for https://github.com/mrtazz/checkmake.git.
    [INFO] Initializing environment for https://github.com/executablebooks/mdformat.
    [INFO] Initializing environment for https://github.com/executablebooks/mdformat:mdformat-gfm.
    [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
    [INFO] Installing environment for https://github.com/mrtazz/checkmake.git.
    [INFO] Once installed this environment will be reused.
    [INFO] This may take a few minutes...
    An unexpected error has occurred: CalledProcessError: command: ('/home/colin/.cache/pre-commit/repoy46vmwin/golangenv-default/.go/bin/go', 'install', './...')
    return code: 1
    stdout: (none)
    stderr:
        error obtaining VCS status: exit status 128
            Use -buildvcs=false to disable VCS stamping.
        error obtaining VCS status: exit status 128
            Use -buildvcs=false to disable VCS stamping.
    Check the log at /home/colin/.cache/pre-commit/pre-commit.log
    

    $ pre-commit --version
    pre-commit 3.2.2
    $ git --version
    git version 2.34.1
    $ lsb_release -a
    No LSB modules are available.
    Distributor ID: Ubuntu
    Description:    Ubuntu 22.04.1 LTS
    Release:        22.04
    Codename:       jammy
    
18. asottile commented on Apr 13, 2023

    

    asottile

    on Apr 13, 2023

    Member

    More actions

    can you strace and figure out why git is mad?
19. colindean commented on Apr 13, 2023

    

    colindean

    on Apr 13, 2023

    More actions

    I can try. I've not used strace before, though.

    One thing I've noticed on this Linux system is that if I run pre-commit install-hooks, the checkmake hook will install correctly and run fine next time I run git commit.

    If I run pre-commit clean and then git commit, pre-commit prepares the hooks and fails with the above error. If I then run pre-commit install-hooks and try to commit again, it works.

    What's the difference in environment between when pre-commit needs to install hooks at commit time versus what happens when install-hooks does its thing?

    👍React with 👍2Reacted by David Caro and ashlah-gdt
20. asottile commented on Apr 13, 2023

    

    asottile

    on Apr 13, 2023

    Member

    More actions

    there shouldn't be a difference -- I haven't been able to reproduce the findings either way
21. colindean commented on Apr 13, 2023

    

    colindean

    on Apr 13, 2023

    More actions

    strace git commit -av output:

    access(".git/hooks/pre-commit", X_OK)   = 0
    pipe2([3, 5], 0)                        = 0
    openat(AT_FDCWD, "/dev/null", O_RDWR|O_CLOEXEC) = 7
    fcntl(7, F_GETFD)                       = 0x1 (flags FD_CLOEXEC)
    fcntl(7, F_SETFD, FD_CLOEXEC)           = 0
    rt_sigprocmask(SIG_SETMASK, ~[RTMIN RT_1], [], 8) = 0
    clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7f23925eaa10) = 10579
    rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
    close(5)                                = 0
    read(3, "", 8)                          = 0
    close(3)                                = 0
    close(7)                                = 0
    wait4(10579, [INFO] Installing environment for https://github.com/mrtazz/checkmake.git.
    [INFO] Once installed this environment will be reused.
    [INFO] This may take a few minutes...
    An unexpected error has occurred: CalledProcessError: command: ('/home/colin/.cache/pre-commit/repoyeyfjm3j/golangenv-default/.go/bin/go', 'install', './...')
    return code: 1
    stdout: (none)
    stderr:
        error obtaining VCS status: exit status 128
            Use -buildvcs=false to disable VCS stamping.
        error obtaining VCS status: exit status 128
            Use -buildvcs=false to disable VCS stamping.
    Check the log at /home/colin/.cache/pre-commit/pre-commit.log
    [{WIFEXITED(s) && WEXITSTATUS(s) == 3}], 0, NULL) = 10579
    --- SIGCHLD {si_signo=SIGCHLD, si_code=CLD_EXITED, si_pid=10579, si_uid=1000, si_status=3, si_utime=149, si_stime=61} ---
    unlink("/home/colin/Source/homebrew-size-analysis/.git/index.lock") = 0
    getpid()                                = 10578
    exit_group(1)                           = ?
    +++ exited with 1 +++
    

    but I think strace isn't attaching to the process(es) launched from .git/hooks/pre-commit, so I altered that to inject strace:

     exec strace --output pre-commit.strace.log "$INSTALL_PYTHON" -mpre_commit "${ARGS[@]}"
    

    The output log is 22 MB. I'm pretty lost in it with the time I have available right now. I've attached it as a ~2.9 MB gzip. Hopefully I'm not leaking anything in this; this Linux system is actually WSL and there's virtually nothing on it.

    pre-commit.strace.log.gz
22. asottile commented on Apr 13, 2023

    

    asottile

    on Apr 13, 2023

    Member

    More actions

    I think with -ff and -o you can get it to follow subprocesses which might help?
23. sarndt commented on Apr 28, 2023

    

    sarndt

    on Apr 28, 2023

    Last edited by sarndt

    More actions

    I can try. I've not used strace before, though.

    One thing I've noticed on this Linux system is that if I run pre-commit install-hooks, the checkmake hook will install correctly and run fine next time I run git commit.

    If I run pre-commit clean and then git commit, pre-commit prepares the hooks and fails with the above error. If I then run pre-commit install-hooks and try to commit again, it works.

    What's the difference in environment between when pre-commit needs to install hooks at commit time versus what happens when install-hooks does its thing?

    I've run into the same problem, this post actually fixed the issue for me too.
    So running

    Running pre-commit install-hooks for some reason is able to download the go-modules when pre-commit is not possible to do so when just running a normal git commit command

    🎉React with 🎉4Reacted by MinimaxHeadroom, Tony Johnson, Jason Santos and Eduardo Mucelli

    ❤️React with ❤️3Reacted by ashlah-gdt, Tony Johnson and Jason Santos
24. znerd commented on Jun 30, 2023

    

    znerd

    on Jun 30, 2023

    More actions

    I'm running into the same issue while running git commit

    • on macOS Ventura 13.4.1,
    • using pre-commit 3.2.0,
    • and git 2.35.1.

    This workaround worked for me: prefix the git commit command with GOFLAGS=-buildvcs=false.

    🚀React with 🚀1Reacted by Ahmed
25. matthewhughes934 commented on Feb 13, 2024

    

    matthewhughes934

    on Feb 13, 2024

    Last edited by matthewhughes934

    Contributor

    More actions

    I just ran into this. I believe the cause is the fact go install is called with a copy of the environment

    pre-commit/pre_commit/languages/golang.py

    Line 144 in 15bd0c7

    env = dict(os.environ, GOPATH=gopath)

    which can contain GIT_INDEX_FILE when git commit is being run. Here's a reproduction using pre-commit (tested on pre-commit 3.3.3, go version go1.21.6 linux/amd64, though I expect the same behaviour for any Go version >= 1.18 when Go started including VCS info in builds):

    repo="$(mktemp --directory)"
    git init "$repo"
    cd "$repo"
    cat <<EOF >.pre-commit-config.yaml
    repos:
        # repo doesn't matter, anything using Go
    -   repo: https://github.com/segmentio/golines
        rev: v0.10.0
        hooks:
        -   id: golines
    EOF
    git add .pre-commit-config.yaml
    pre-commit install
    # setup some fresh caches to ensure we do a full download+build
    mkdir gocache gomodcache pre-commit-cache
    GOFLAGS='-x' GOCACHE="$PWD/gocache" GOMODCACHE="$PWD/gomodcache" PRE_COMMIT_HOME="$PWD/pre-commit-cache" git commit --all --message 'Install pre-commit'

    GOFLAGS='-x' forces go to print commands as it runs them and reports:

        <--- SNIP: a bunch of download logs --->
        cd /tmp/tmp.o1rMm1SgXK/pre-commit-cache/repopbyr_tp4
        git status --porcelain
        # cd /tmp/tmp.o1rMm1SgXK/pre-commit-cache/repopbyr_tp4; git status --porcelain
        fatal: unable to read 715dc4303df786fdbed5723d06fcca76ba0c9138
        error obtaining VCS status: exit status 128
        	Use -buildvcs=false to disable VCS stamping.
        error obtaining VCS status: exit status 128
        	Use -buildvcs=false to disable VCS stamping.
    Check the log at /tmp/tmp.o1rMm1SgXK/pre-commit-cache/pre-commit.log
    

    Note the line fatal: unable to read 715dc4303df786fdbed5723d06fcca76ba0c9138: /tmp/tmp.o1rMm1SgXK/pre-commit-cache/repopbyr_tp4 is the clone of the repo we're trying to build, but 715dc4303df786fdbed5723d06fcca76ba0c9138 is a blob in the repo we're committing in.

    Maybe the env needs to be cleaned with something like

    pre-commit/pre_commit/git.py

    Line 27 in 15bd0c7

    def no_git_env(_env: Mapping[str, str] | None = None) -> dict[str, str]:

    before running go install? Or, as others have noted setting the buildvcs build flag: go install -buildvcs=false ./...

    Here's a standalone reproduction, install this under .git/hooks/pre-commit and run go commit -a with GOCACHE and GOMODCACHE pointing to some clean caches (like above, so go actually tries to build something, and doesn't just reuse the cache):

    #!/usr/bin/env bash
    
    set -o errexit -o pipefail -o nounset
    
    dest="$(mktemp --directory)"
    trap 'rm -rf -- "$dest"' EXIT
    # ensure GIT_INDEX_FILE is unset during clone, I believe `pre-commit` does this
    # otherwise things can fail earlier on, or (confusingly) work fine
    env --unset GIT_INDEX_FILE git clone --depth 1 https://github.com/segmentio/golines "$dest"
    
    cd "$dest"
    GOFLAGS='-x -v' go install ./...

    NOTE: I found this didn't reproduce unless the -a/--all flag was passed to git commit: in this case GIT_INDEX_FILE would be an absolute path like GIT_INDEX_FILE=/tmp/repo/.git/index.lock but otherwise might be a relative path like: GIT_INDEX_FILE=.git/index in which case things can actually work.
26. asottile commented on Feb 18, 2024

    

    asottile

    on Feb 18, 2024

    Member

    More actions

    finally a reproduction! thank you this should be easy enough to fix with the git helper

    🎉React with 🎉2Reacted by Matthew Hughes and Maxime Brunet