This repository was archived by the owner on Oct 2, 2018. It is now read-only.

Repository navigation

Commit 2386a59

committed

Catch exception when pip not already installed

When pip is not already installed, `current_installed_version` throws an uncaught `Mixlib::ShellOut::ShellCommandFailed`. It tries to catch a `Chef::Exceptions::ShellCommandFailed`, but that doesn't work. This patch makes it unconditionally return `nil` if an exception occurs, so that pip can be installed properly. There's probably a better way to fix this, but alas, I am not well-versed in Ruby.

1 parent bb17707 commit 2386a59Copy full SHA for 2386a59

1 file changed

providers
- pip.rb

`‎providers/pip.rb‎`

-Original file line number
+Diff line change
     end
     p = shell_out!(version_check_cmd)
     p.stdout.split(delimeter)[1].strip
 -  rescue Chef::Exceptions::ShellCommandFailed
 +  else
   end
 end

Comments

(0)