Repository navigation
[Bug]: Incorrect DeprecatedInsinto for non-menu items in /usr/share/applications #726
Description
Is there an existing issue for this?
- I have searched the existing issues
Current Behavior
See ef042cf60b50500d364675af5961808eb8941298 for an example.
pkgcheck emits DeprecatedInsinto for non-menu items installed into /usr/share/applications with this snippet:
insinto /usr/share/applications/
newins "${FILESDIR}"/mimeapps.list kde-mimeapps.list
kde-plasma/plasma-mimeapps-list
DeprecatedInsinto: version 3: deprecated insinto usage (use domenu or newmenu from desktop.eclass instead), line 26: insinto /usr/share/applications/
Expected Behavior
No bogus warning.
pkgcheck version
pkgcheck 0.10.3
pkgcore version
pkgcore 0.12.29
Activity
arthurzam commentedon Jan 25, 2025
Hmm, changing the code of
DeprecatedInsintois non trivial, since it uses regex to detect just calls toinsint ${DIR}. It means I would detect next lines if they attempt to install "*.desktop".On the other hand, while somewhat ugly, would using
newmenu "${FILESDIR}"/mimeapps.list kde-mimeapps.listwork "by mistake"?thesamesam commentedon Jan 25, 2025
I think that would work by mistake, yeah. @parona-source points out maybe this is a good case for a suppression instead and to keep the check as-is?