if.alwaysTrue when found in traits isn't reported correctly through context of a user class #14932

Activity

1. staabm

   added

   bug

   on Jul 13, 2026
2. mabar commented on Jul 21, 2026

   

   mabar

   on Jul 21, 2026

   Contributor

   More actions

   This error occurs since phpstan/phpstan-src#5309 - reproducible from 2.2.0 up to latest 2.2.x-dev@ce1a7f1 (upcoming 2.2.6, post related fix phpstan/phpstan-src#6033)

   I was able to reliably replicate it by running phpstan on a single core, with a single class that uses a trait and reports an error. Error is baselined. Then there is a simple repeatable loop:

   • run phpstan -> no errors
   • add second class that uses the trait and run phpstan -> error
   • run phpstan 1 to N times (without any changes) -> no error
     Removing the second class and running the same loop replicates the behavior.

   phpstan-trait-flicker.zip
   This is a minimal reproduction. Just extract the archive, cd to directory and run ./replicate.sh

   Likely root cause - the winner therefore depends on the iteration order of collected data, and that order is unstable:

   • Cold run: ParallelAnalyser appends $collectedData[$file] in worker-message arrival order — a race between worker processes.
   • Warm run: collected data is replayed from the result cache, which ResultCacheManager::save() ksorts — deterministic alphabetical order, different from the arrival order of the run that populated it.
   • Partial run with a new file: mergeCollectedData() preserves key positions for existing files and appends new files at the end — so a newly added using class wins exactly once, until the next run replays the ksorted save.

   Because CollectedDataNode rules run in AnalyserResultFinalizer after the result cache is saved (AnalyseApplication), these errors are never stored in the cache's error map and are re-derived — with a potentially different winner — on every run.
3. pelletiermaxime commented on Aug 12, 2026

   

   pelletiermaxime

   on Aug 12, 2026

   Last edited by pelletiermaxime

   More actions

   I believe I ran into the same problem after updating from 2.2.1 to 2.2.8. I got errors that alwaysTrue or alwaysFalse was not matched, regenerated the baseline and then in my pipeline I got this:

    Line   app/Models/Db/Training.php                                            
    ------ ---------------------------------------------------------------------- 
            Ignored error pattern #^Negated boolean expression is always          
            false\.$# (booleanNot.alwaysFalse) in path                            
            /builds/hexfit/hexfit/api/backend-laravel/app/Models/Db/Training.php  
            was not matched in reported errors.                                   
            🪪  ignore.unmatched (non-ignorable)           
   ----- ----------------------------------------------------------------------- 
     Line   app/Models/Traits/SharingObject.php                                    
    ------ ----------------------------------------------------------------------- 
     37     Negated boolean expression is always false.                            
            🪪  booleanNot.alwaysFalse          
   
   

   The Training class uses the Trait HexfitModel. My AI just patched the baseline file to fix my pipeline:

   

   👍React with 👍1Reacted by Marek Bartoš
4. ondrejmirtes

   closed this as completedin phpstan-src#6280on Aug 26, 2026
5. github-actions commented on Sep 27, 2026

   

   github-actionsBot

   on Sep 27, 2026 – with GitHub Actions

   More actions

   This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
6. github-actions

   locked as resolved and limited conversation to collaborators on Sep 27, 2026