Skip to content

Array might not have offset, if array is deep #13637

Open
Open
Array might not have offset, if array is deep#13637
Labels
bug
Milestone
Easy fixes

Description

@imhdCePo
imhdCePo
opened on Oct 5, 2025

Bug report

Somewhere between version 2.1.22 and 2.1.30, the following started to be a problem:

https://phpstan.org/r/b6995229-1713-43e7-a6eb-a761ceec3b82

If array is very deep, only first offset of an array is considered and other are ignored in the function.

Code snippet that reproduces the problem

https://phpstan.org/r/b6995229-1713-43e7-a6eb-a761ceec3b82

Expected output

No errors.

Did PHPStan help you today? Did it make you happy in any way?

No response

Activity

  1. ondrejmirtes commented on Oct 6, 2025

    @ondrejmirtes
    ondrejmirtes
    on Oct 6, 2025
    Member

    Easy work around is to do a single assignment: https://phpstan.org/r/a89086d8-c68a-4ecd-967a-c2ec872ea2c0

    But yeah, it should not report an error, especially when it works for two levels nesting, but not for three.

  2. ondrejmirtes
    added
    bug
    on Oct 6, 2025
  3. ondrejmirtes
    added this to the Easy fixes milestone on Oct 6, 2025

  4. ondrejmirtes commented on Oct 6, 2025

    @ondrejmirtes
    ondrejmirtes
    on Oct 6, 2025
    Member

    /cc @staabm

  5. phpstan-bot
    added a commit that references this issue on Feb 17, 2026

    Fix deeply nested array assignments marking keys as optional in loops

    ce6e5e2
  6. phpstan-bot
    added 2 commits that reference this issue on Mar 9, 2026

    Fix deeply nested array offset tracking losing required keys

    40ff6dd

    Fix deep nested array dim assignment marking keys as optional

    73870d5
  7. staabm
    added a commit that references this issue on Mar 24, 2026

    Fix deep nested array dim assignment marking keys as optional

    f88cd9c

  8. phpstan-bot commented on May 20, 2026

    @phpstan-bot
    phpstan-bot
    on May 20, 2026
    Contributor

    @imhdCePo After the latest push in 2.2.x, PHPStan now reports different result with your code snippet:

    @@ @@
-18: Function DoesNotWork() should return array<int, array<int, array<int, array{abc: int, def: int, ghi: int}>>> but returns array<int<0, 4>, non-empty-array<int<0, 8>, non-empty-array<int<1, 9>, array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}>>>.
+18: Function DoesNotWork() should return array<int, array<int, array<int, array{abc: int, def: int, ghi: int}>>> but returns array<int<0, 4>, non-empty-array<int<0, 8>, non-empty-array<int<1, 9>, non-empty-array<'abc'|'def'|'ghi', int<0, max>>>>>.
    Full report
    Line Error
    18 `Function DoesNotWork() should return array<int, array<int, array<int, array{abc: int, def: int, ghi: int}>>> but returns array<int<0, 4>, non-empty-array<int<0, 8>, non-empty-array<int<1, 9>, non-empty-array<'abc'
  9. ondrejmirtes
    added a commit that references this issue on May 21, 2026

    Preserve integer range bounds for sealed array values in loop general…

    1065a0f

  10. phpstan-bot commented on May 21, 2026

    @phpstan-bot
    phpstan-bot
    on May 21, 2026
    Contributor

    @imhdCePo After the latest push in 2.2.x, PHPStan now reports different result with your code snippet:

    @@ @@
-18: Function DoesNotWork() should return array<int, array<int, array<int, array{abc: int, def: int, ghi: int}>>> but returns array<int<0, 4>, non-empty-array<int<0, 8>, non-empty-array<int<1, 9>, array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}>>>.
+18: Function DoesNotWork() should return array<int, array<int, array<int, array{abc: int, def: int, ghi: int}>>> but returns array<int<0, 4>, non-empty-array<int, non-empty-array<int<1, 9>, array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}>>>.
    Full report
    Line Error
    18 Function DoesNotWork() should return array<int, array<int, array<int, array{abc: int, def: int, ghi: int}>>> but returns array<int<0, 4>, non-empty-array<int, non-empty-array<int<1, 9>, array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}>>>.

  11. phpstan-bot commented on Sep 11, 2026

    @phpstan-bot
    phpstan-bot
    on Sep 11, 2026
    Contributor

    @imhdCePo After the latest push in 2.3.x, PHPStan now reports different result with your code snippet:

    @@ @@
-18: Function DoesNotWork() should return array<int, array<int, array<int, array{abc: int, def: int, ghi: int}>>> but returns array<int<0, 4>, non-empty-array<int<0, 8>, non-empty-array<int<1, 9>, array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}>>>.
+12: Variable $l is never read.
+18: Function DoesNotWork() should return array<int, array<int, array<int, array{abc: int, def: int, ghi: int}>>> but returns array<int<0, 4>, non-empty-array<int, non-empty-array<int<1, 9>, array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}>>>.
+29: Variable $k is never read.
+30: Variable $l is never read.
    Full report
    Line Error
    12 Variable $l is never read.
    18 Function DoesNotWork() should return array<int, array<int, array<int, array{abc: int, def: int, ghi: int}>>> but returns array<int<0, 4>, non-empty-array<int, non-empty-array<int<1, 9>, array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}>>>.
    29 Variable $k is never read.
    30 Variable $l is never read.

  12. phpstan-bot commented on Sep 11, 2026

    @phpstan-bot
    phpstan-bot
    on Sep 11, 2026
    Contributor

    @ondrejmirtes After the latest push in 2.3.x, PHPStan now reports different result with your code snippet:

    @@ @@
-No errors
+12: Variable $l is never read.
    Full report
    Line Error
    12 Variable $l is never read.

  13. phpstan-bot commented on Sep 15, 2026

    @phpstan-bot
    phpstan-bot
    on Sep 15, 2026
    Contributor

    @imhdCePo After the latest push in 2.3.x, PHPStan now reports different result with your code snippet:

    @@ @@
-18: Function DoesNotWork() should return array<int, array<int, array<int, array{abc: int, def: int, ghi: int}>>> but returns array<int<0, 4>, non-empty-array<int<0, 8>, non-empty-array<int<1, 9>, array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}>>>.
+12: Variable $l is never read.
+18: Function DoesNotWork() should return array<int, array<int, array<int, array{abc: int, def: int, ghi: int}>>> but returns array<int<0, 4>, non-empty-array<int<0, 8>, non-empty-array{3?: array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}, 1?: array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}, 2?: array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}, 4?: array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}, 5?: array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}, 6?: array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}, 7?: array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}, 8?: array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}, ...}>>.
+29: Variable $k is never read.
+30: Variable $l is never read.
    Full report
    Line Error
    12 Variable $l is never read.
    18 Function DoesNotWork() should return array<int, array<int, array<int, array{abc: int, def: int, ghi: int}>>> but returns array<int<0, 4>, non-empty-array<int<0, 8>, non-empty-array{3?: array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}, 1?: array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}, 2?: array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}, 4?: array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}, 5?: array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}, 6?: array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}, 7?: array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}, 8?: array{abc: int<0, 4>, def?: int<0, 4>, ghi?: int<0, 4>}, ...}>>.
    29 Variable $k is never read.
    30 Variable $l is never read.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions