Skip to content

Commit 4fdd7f6

Browse files
committed
Refactor ConfigStorage\RelationTest test class
Inline the dbi and dbiDummy properties. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
1 parent 34a6681 commit 4fdd7f6

4 files changed

Lines changed: 238 additions & 216 deletions

File tree

‎test/classes/AbstractTestCase.php‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -119,17 +119,6 @@ protected function assertAllSelectsConsumed(): void
119119
);
120120
}
121121

122-
protected function assertAllErrorCodesConsumed(): void
123-
{
124-
if ($this->dummyDbi->hasUnUsedErrors() === false) {
125-
$this->assertTrue(true);// increment the assertion count
126-
127-
return;
128-
}
129-
130-
$this->fail('Some error codes where not used !');
131-
}
132-
133122
protected function loadContainerBuilder(): void
134123
{
135124
$GLOBALS['containerBuilder'] = Core::getContainerBuilder();

‎test/classes/CharsetsTest.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public function testGetServerCharset(): void
4747
$charset = Charsets::getServerCharset($dbi, false);
4848
$this->assertSame('utf8mb4', $charset->getName());
4949

50-
$this->assertAllQueriesConsumed();
50+
$dummyDbi->assertAllQueriesConsumed();
5151
}
5252

5353
public function testFindCollationByName(): void

0 commit comments

Comments
 (0)