Skip to content

Commit 25fe766

Browse files
MauricioFauthMauricioFauth
committed
Fix tests marked as incomplete
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
1 parent 91403fc commit 25fe766

2 files changed

Lines changed: 27 additions & 22 deletions

File tree

‎test/classes/Controllers/Sql/EnumValuesControllerTest.php‎

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -39,21 +39,22 @@ public function testGetEnumValuesError(): void
3939
{
4040
$this->dummyDbi->addResult('SHOW COLUMNS FROM `cvv`.`enums` LIKE \'set\'', false);
4141

42-
$_POST = [
43-
'ajax_request' => true,
44-
'db' => 'cvv',
45-
'table' => 'enums',
46-
'column' => 'set',
47-
'curr_value' => 'b&c',
48-
];
49-
$GLOBALS['db'] = $_POST['db'];
50-
$GLOBALS['table'] = $_POST['table'];
42+
$GLOBALS['db'] = 'cvv';
43+
$GLOBALS['table'] = 'enums';
44+
45+
$request = $this->createStub(ServerRequest::class);
46+
$request->method('getParsedBodyParam')->willReturnMap([
47+
['db', null, 'cvv'],
48+
['table', null, 'enums'],
49+
['column', null, 'set'],
50+
['curr_value', null, 'b&c'],
51+
]);
5152

5253
$GLOBALS['containerBuilder']->setParameter('db', $GLOBALS['db']);
5354
$GLOBALS['containerBuilder']->setParameter('table', $GLOBALS['table']);
5455
/** @var EnumValuesController $sqlController */
5556
$sqlController = $GLOBALS['containerBuilder']->get(EnumValuesController::class);
56-
$sqlController($this->createStub(ServerRequest::class));
57+
$sqlController($request);
5758

5859
$this->assertResponseWasNotSuccessfull();
5960

@@ -87,21 +88,22 @@ public function testGetEnumValuesSuccess(): void
8788
]
8889
);
8990

90-
$_POST = [
91-
'ajax_request' => true,
92-
'db' => 'cvv',
93-
'table' => 'enums',
94-
'column' => 'set',
95-
'curr_value' => 'b&c',
96-
];
97-
$GLOBALS['db'] = $_POST['db'];
98-
$GLOBALS['table'] = $_POST['table'];
91+
$GLOBALS['db'] = 'cvv';
92+
$GLOBALS['table'] = 'enums';
93+
94+
$request = $this->createStub(ServerRequest::class);
95+
$request->method('getParsedBodyParam')->willReturnMap([
96+
['db', null, 'cvv'],
97+
['table', null, 'enums'],
98+
['column', null, 'set'],
99+
['curr_value', null, 'b&c'],
100+
]);
99101

100102
$GLOBALS['containerBuilder']->setParameter('db', $GLOBALS['db']);
101103
$GLOBALS['containerBuilder']->setParameter('table', $GLOBALS['table']);
102104
/** @var EnumValuesController $sqlController */
103105
$sqlController = $GLOBALS['containerBuilder']->get(EnumValuesController::class);
104-
$sqlController($this->createStub(ServerRequest::class));
106+
$sqlController($request);
105107

106108
$this->assertResponseWasSuccessfull();
107109

‎test/classes/Controllers/Table/ReplaceControllerTest.php‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ public function testReplace(): void
7575
$_POST['db'] = $GLOBALS['db'];
7676
$_POST['table'] = $GLOBALS['table'];
7777
$_POST['ajax_request'] = 'true';
78-
$_POST['sql_query'] = '';
7978
$_POST['clause_is_unique'] = 1;
8079
$_POST['where_clause'] = [
8180
'`test`.`ser` = 2',
@@ -106,6 +105,11 @@ public function testReplace(): void
106105
],
107106
];
108107

108+
$request = $this->createStub(ServerRequest::class);
109+
$request->method('getParsedBodyParam')->willReturnMap([
110+
['sql_query', null, ''],
111+
]);
112+
109113
$dummyDbi = $this->createDbiDummy();
110114
$dbi = $this->createDatabaseInterface($dummyDbi);
111115
$relation = new Relation($dbi);
@@ -121,7 +125,6 @@ public function testReplace(): void
121125
$dbi
122126
);
123127

124-
$request = $this->createStub(ServerRequest::class);
125128
$sqlController = new SqlController(
126129
$response,
127130
$template,

0 commit comments

Comments
 (0)