Skip to content

Numeric table columns in report should be aligned right #975

Description

@donquixote

In a cli report table, to properly compare numbers, columns with numbers should:

  • be aligned right (\STR_PAD_LEFT).
  • use the same measuring unit (e.g. not ms in one record, but µs in another record).
  • ideally, a unit should be used where all values are > 1, so that big numbers visually stick out with additional digits to the left.
    (for these last points I currently use --mode=throughput --time-unit=s as cli parameters)

For the first point, I found that the following addition in TableRenderer::render() has the desired effect for the main table:

        $style = (new TableStyle())->setPadType(\STR_PAD_LEFT);
        $nColumns = \count($object->columnNames());
        for ($iCol = 2; $iCol < $nColumns; ++$iCol) {
            $consoleTable->setColumnStyle($iCol, $style);
        }

However, this is obviously the wrong place to do this.
I am hard-coding the rule that every column except the first two should be aligned right, which is true for the final overview table but not universally for every table.

What the code example shows is that the symfony console table component can align numbers right.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions