Skip to content

Commit de7c57e

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "Fix bug 2114951" into stable/2024.2
2 parents 3514a5c + 8ffd144 commit de7c57e

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎nova/api/openstack/compute/schemas/servers.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@
2727
'volume_id': parameter_types.volume_id,
2828
'snapshot_id': parameter_types.image_id,
2929
'volume_size': parameter_types.volume_size,
30-
# Do not allow empty device names and number values and
31-
# containing spaces(defined in nova/block_device.py:from_api())
30+
# Do not allow empty device names or spaces in name (defined in
31+
# nova/block_device.py:validate_device_name())
3232
'device_name': {
3333
'type': 'string', 'minLength': 1, 'maxLength': 255,
34-
'pattern': '^[a-zA-Z0-9._-r/]*$',
34+
'pattern': '^[a-zA-Z0-9._/-]*$',
3535
},
3636
# Defined as boolean in nova/block_device.py:from_api()
3737
'delete_on_termination': parameter_types.boolean,

‎nova/tests/unit/api/openstack/compute/test_volumes.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ def test_create_root_volume_bdm_v2_reproducer_2114951(self):
245245
req.body = jsonutils.dump_as_bytes(body)
246246
req.headers['content-type'] = 'application/json'
247247
res = req.get_response(fakes.wsgi_app_v21())
248-
self.assertEqual(400, res.status_int)
248+
self.assertEqual(202, res.status_int)
249249

250250

251251
class VolumeApiTestV21(test.NoDBTestCase):

0 commit comments

Comments
 (0)