Repository navigation
[BUG] Tests not running in CI #378
Description
Describe the bug
The Test and Lint workflow is no longer running successfully in CI. The last successful run was December 1. Linting is successful, unit tests are successful, but e2e tests never run, and it times out after 6 hours.
First broken run was on this PR- #372
https://github.com/oddbird/css-anchor-positioning/actions/workflows/test.yml
Activity
jamesnw commentedon Feb 5, 2026
Locally, it runs successfully in Node v24.11.1, and hangs in Node v24.12.0. Notably, type stripping is no longer experimental, so the flag is no longer
--no-experimental-strip-types, but rather--no-strip-types.nodejs/node#60600
However, I'm not convinced this isn't a red herring. On Node v24.12.0:
--no-experimental-strip-typesit hangs indefinitely--no-strip-typesit hangs indefinitelySyntaxError: TypeScript enum is not supported in strip-only mode.The simplest way to get back up and running would be to hardcode the Node version to v24.11.1, but I'd rather fix the underlying issue.
A related Playwright issue has some workarounds that I haven't found to work.
@jgerigmeyer Do you have any thoughts on the underlying issue? Or should we just pin the Node version?
break-stuff commentedon Feb 9, 2026
There are failing tests, but they are being masked by the script parallelization. I updated the task to stop when any of the scripts fail using the
--raceflag whererun-pis called and I was able to see what was failing.jamesnw commentedon Feb 9, 2026
@break-stuff I'm curious about your methodology for discovering these issues.
I'm able to reproduce the hang on Node v24.12.0 without any parallel tasks (Just running
npm run test:e2e, which isNODE_OPTIONS='--no-experimental-strip-types' playwright test tests/e2e/).For the failing tests, where did you observe them failing? All e2e tests are passing locally on main on v24.11.1, and were passing recently in CI. Which branch and Node version did you see the tests failing?
break-stuff commentedon Feb 9, 2026
When I ran the parts of the
tests:ciindividually, those were the tests that were failing for me.break-stuff commentedon Feb 10, 2026
Sorry, the node version I'm running is vv20.19.5.
break-stuff commentedon Feb 10, 2026
Upgrading my node version resulted in another error regarding the enums, so I needed to include
NODE_OPTIONS='--no-experimental-strip-types'in thetest:e2escript. After replacing it, everything seems to be passing again.jamesnw commentedon Feb 10, 2026
After doing some spelunking into the Playwright source, it seems to be hanging at this line-
https://github.com/microsoft/playwright/blob/a051ceb8e1302293ec42d4ad01d7f6325cbbfcf9/packages/playwright/src/transform/transform.ts#L209
We have Playwright pinned so that we are testing old browser versions that need to be polyfilled. I suspect that Node 24.12 introduced a change that broke importing ESM modules in this way. Since we can't upgrade Playwright to a version that is compatible with Node 24.12, I think we need to pin our Node version to Node 24.11. I'll open a PR to test that out in CI.
jamesnw commentedon Feb 10, 2026
@break-stuff I opened #379 to verify that pinning Node works as expected. It looks like adding
--racewas causing the e2e tests to fail silently, and never run.break-stuff commentedon Feb 10, 2026
Oh, interesting. Ok, I'll remove it.