Skip to content

Add unassigned scripts to open specific settings panels #18313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 7 commits into from
Jun 24, 2025
Merged

Add unassigned scripts to open specific settings panels #18313

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
97c2ac8
Add unassigned scripts to open Vision settings panel
Jun 23, 2025
923a10d
Add scripts to open Add-on Store and Advanced settings
Jun 23, 2025
7772bbc
Add scripts to open Windows OCR settings
Jun 23, 2025
c3e20d0
Merge remote-tracking branch 'nvaccess/master' into openVision
Jun 23, 2025
eb8947a
Change log
Jun 23, 2025
8631475
Pre-commit auto-fix
pre-commit-ci[bot] Jun 23, 2025
a7e8c1f
Apply suggestions from code review
seanbudd Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions source/globalCommands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3358,6 +3358,15 @@ def script_activateBrailleSettingsDialog(self, gesture):
def script_activateAudioSettingsDialog(self, gesture):
wx.CallAfter(gui.mainFrame.onAudioSettingsCommand, None)

@script(
# Translators: Input help mode message for go to vision settings command.
description=_("Shows NVDA's vision settings"),
category=SCRCAT_CONFIG,
)
@gui.blockAction.when(gui.blockAction.Context.MODAL_DIALOG_OPEN)
def script_activateVisionSettingsDialog(self, gesture):
Comment thread
seanbudd marked this conversation as resolved.
Resolved
wx.CallAfter(gui.mainFrame.onVisionSettingsCommand, None)

@script(
# Translators: Input help mode message for go to keyboard settings command.
description=_("Shows NVDA's keyboard settings"),
Expand Down Expand Up @@ -3435,6 +3444,33 @@ def script_activateDocumentFormattingDialog(self, gesture):
def script_activateRemoteAccessSettings(self, gesture: "inputCore.InputGesture"):
wx.CallAfter(gui.mainFrame.onRemoteAccessSettingsCommand, None)

@script(
# Translators: Input help mode message for go to Add-on Store settings command.
description=_("Shows NVDA's Add-on Store settings"),
category=SCRCAT_CONFIG,
)
@gui.blockAction.when(gui.blockAction.Context.MODAL_DIALOG_OPEN)
def script_activateAddonStoreSettings(self, gesture: "inputCore.InputGesture"):
wx.CallAfter(gui.mainFrame.onAddonStoreSettingsCommand, None)

@script(
# Translators: Input help mode message for go to Windows OCR settings command.
description=_("Shows NVDA's Windows OCR settings"),
category=SCRCAT_CONFIG,
)
@gui.blockAction.when(gui.blockAction.Context.MODAL_DIALOG_OPEN)
def script_activateWindowsOCRSettings(self, gesture: "inputCore.InputGesture"):
wx.CallAfter(gui.mainFrame.onUwpOcrCommand, None)

@script(
# Translators: Input help mode message for go to Advanced settings command.
description=_("Shows NVDA's Advanced settings"),
category=SCRCAT_CONFIG,
)
@gui.blockAction.when(gui.blockAction.Context.MODAL_DIALOG_OPEN)
def script_activateAdvancedSettings(self, gesture: "inputCore.InputGesture"):
wx.CallAfter(gui.mainFrame.onAdvancedSettingsCommand, None)

@script(
# Translators: Input help mode message for opening default dictionary dialog.
description=_("Shows the NVDA default dictionary dialog"),
Expand Down
16 changes: 15 additions & 1 deletion source/gui/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@
# Be careful when removing, and only do in a compatibility breaking release.
from .exit import ExitDialog
from .settingsDialogs import (
AddonStorePanel,
AdvancedPanel,
AudioPanel,
BrailleDisplaySelectionDialog,
BrailleSettingsPanel,
Expand All @@ -60,13 +62,14 @@
NVDASettingsDialog,
ObjectPresentationPanel,
RemoteSettingsPanel,
ReviewCursorPanel,
SettingsDialog,
SpeechSettingsPanel,
SpeechSymbolsDialog,
SynthesizerSelectionDialog,
TouchInteractionPanel,
ReviewCursorPanel,
UwpOcrPanel,
VisionSettingsPanel,
)
from .startupDialogs import WelcomeDialog
from .inputGestures import InputGesturesDialog
Expand Down Expand Up @@ -343,6 +346,9 @@ def onBrailleSettingsCommand(self, evt):
def onAudioSettingsCommand(self, evt: wx.CommandEvent):
self.popupSettingsDialog(NVDASettingsDialog, AudioPanel)

def onVisionSettingsCommand(self, evt: wx.CommandEvent):
self.popupSettingsDialog(NVDASettingsDialog, VisionSettingsPanel)

def onKeyboardSettingsCommand(self, evt):
self.popupSettingsDialog(NVDASettingsDialog, KeyboardSettingsPanel)

Expand All @@ -367,13 +373,21 @@ def onBrowseModeCommand(self, evt):
def onDocumentFormattingCommand(self, evt):
self.popupSettingsDialog(NVDASettingsDialog, DocumentFormattingPanel)

@blockAction.when(blockAction.Context.SECURE_MODE)
def onAddonStoreSettingsCommand(self, evt):
Comment thread
seanbudd marked this conversation as resolved.
Resolved
self.popupSettingsDialog(NVDASettingsDialog, AddonStorePanel)

def onUwpOcrCommand(self, evt):
self.popupSettingsDialog(NVDASettingsDialog, UwpOcrPanel)

@blockAction.when(blockAction.Context.SECURE_MODE)
def onRemoteAccessSettingsCommand(self, evt):
self.popupSettingsDialog(NVDASettingsDialog, RemoteSettingsPanel)

@blockAction.when(blockAction.Context.SECURE_MODE)
def onAdvancedSettingsCommand(self, evt):
Comment thread
seanbudd marked this conversation as resolved.
Resolved
self.popupSettingsDialog(NVDASettingsDialog, AdvancedPanel)

@blockAction.when(blockAction.Context.SECURE_MODE)
def onSpeechSymbolsCommand(self, evt):
self.popupSettingsDialog(SpeechSymbolsDialog)
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
### New Features

* In Microsoft Word, the new view is now reported when using the shortcuts to switch to page view (`control+alt+p`) or outline view (`control+alt+o`). (#18091, @CyrilleB79)
* Unassigned commands have been added to open NVDA settings dialog in the following categories: Vision, Windows OCR, Add-on Store and Advanced. (#18313, @CyrilleB79)
Comment thread
seanbudd marked this conversation as resolved.
Resolved

### Changes

Expand Down