Skip to content

Enable unicode normalization by default for speech #17017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 8 commits into from
Sep 9, 2024
Merged

Enable unicode normalization by default for speech #17017

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b723346
Enable unicode normalization by default for speech
LeonarddeR Aug 13, 2024
4807534
Update changes
LeonarddeR Aug 30, 2024
d04c74a
Apply suggestions from code review
SaschaCowley Sep 4, 2024
9cc014e
Merge branch 'master' into defaultNormalize
SaschaCowley Sep 4, 2024
354ba37
Moved changes to 2025.1
SaschaCowley Sep 5, 2024
9dd2655
Restored accidentally deleted 2024.4 changes entry
SaschaCowley Sep 6, 2024
54d3bfa
Merge branch 'master' into defaultNormalize
SaschaCowley Sep 6, 2024
7e54bcd
Disable unicode normalization in system tests
LeonarddeR Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/config/configSpec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
# symbolLevel: One of the characterProcessing.SymbolLevel values.
symbolLevel = integer(default=100)
trustVoiceLanguage = boolean(default=true)
unicodeNormalization = featureFlag(optionsEnum="BoolFlag", behaviorOfDefault="disabled")
unicodeNormalization = featureFlag(optionsEnum="BoolFlag", behaviorOfDefault="enabled")
reportNormalizedForCharacterNavigation = boolean(default=true)
# Deprecated in 2025.1
includeCLDR = boolean(default=True)
Expand Down
2 changes: 2 additions & 0 deletions user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ The available options are:
* The `-c`/`--config-path` and `--disable-addons` command line options are now respected when launching an update from within NVDA. (#16937)
* eSpeak NG has been updated to 1.52-dev commit `961454ff`. (#16775)
* Added new languages Faroese and Xextan.
* The default state of Unicode Normalization for speech output has been changed to enabled. (#17017, @LeonarddeR).
Comment thread
SaschaCowley marked this conversation as resolved.
Resolved
* You can still disable this functionality in the speech settings categorie in the NVDA Settings dialog.
Comment thread
SaschaCowley marked this conversation as resolved.
Resolved

### Bug Fixes

Expand Down
4 changes: 2 additions & 2 deletions user_docs/en/userGuide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1906,8 +1906,8 @@ If you find that NVDA is reading punctuation in the wrong language for a particu
##### Unicode normalization {#SpeechUnicodeNormalization}
| . {.hideHeaderRow} |.|
|---|---|
|Options |Default (Disabled), Enabled, Disabled|
|Default |Disabled|
|Options |Default (Enabled), Enabled, Disabled|
|Default |Enabled|

When this option is enabled, unicode normalization is performed on the text that is spoken by NVDA.
This is beneficial when speaking characters that can be represented in several forms.
Expand Down