Skip to content

Fix right-to-left layout direction issues #12181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 17 commits into from
Mar 18, 2021
Merged

Fix right-to-left layout direction issues #12181

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
23ed95e
move to supported usage of wx.StaticBoxSizer
seanbudd Mar 4, 2021
79af2fb
fix flake8 issues
seanbudd Mar 16, 2021
538389e
Merge remote-tracking branch 'origin/master' into fix-8859
seanbudd Mar 16, 2021
4e29c7d
set layout on mainframe for locale
seanbudd Mar 16, 2021
9cfc2d7
fix lint
seanbudd Mar 17, 2021
b31a61f
Merge branch 'master' into fix-8859
seanbudd Mar 17, 2021
f241a04
move out wx import
seanbudd Mar 17, 2021
39ec7d1
use better typing and naming
seanbudd Mar 17, 2021
503675d
remove unused variable
seanbudd Mar 17, 2021
560c278
apply DRY
seanbudd Mar 17, 2021
16d7477
undo risky import change
seanbudd Mar 17, 2021
ce2c5f2
fix lint
seanbudd Mar 17, 2021
68e62cb
undo risky import change, fix lint
seanbudd Mar 17, 2021
3484766
fix nose typing read
seanbudd Mar 17, 2021
45460ee
remove unneccessary typing import
seanbudd Mar 17, 2021
304cc6c
Merge remote-tracking branch 'origin/master' into fix-8859
seanbudd Mar 18, 2021
b138918
update changes.t2t
seanbudd Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions source/gui/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,8 +596,10 @@ def initialize():
if mainFrame:
raise RuntimeError("GUI already initialized")
mainFrame = MainFrame()
wxLang = core.getWxLang(languageHandler.getLanguage())
mainFrame.SetLayoutDirection(wxLang.LayoutDirection)
Comment thread
feerrenrut marked this conversation as resolved.
Resolved
wxLang = core.getWxLangOrNone(languageHandler.getLanguage())
if wxLang:
# otherwise the system default will be used
mainFrame.SetLayoutDirection(wxLang.LayoutDirection)
wx.GetApp().SetTopWindow(mainFrame)
# In wxPython >= 4.1,
# wx.CallAfter no longer executes callbacks while NVDA's main thread is within apopup menu or message box.
Expand Down
3 changes: 2 additions & 1 deletion source/languageHandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,8 @@ def setLanguage(lang):
# #9207: Python 3.8 adds gettext.pgettext, so add it to the built-in namespace.
trans.install(names=["pgettext"])

def getLanguage():

def getLanguage() -> str:
return curLang

def normalizeLanguage(lang):
Expand Down