Comment 9 by jteh on 2014-08-29 07:24
Sorry for taking so long to get to this.

This is really good work. Thanks!

Comments:

One major UI concern I have is that I (and probably others) am used to pressing NVDA+q and then y for yes. While this is pretty silly (I may as well just disable the dialog if I'm going to do this), it's been like this for years now and this is something one does often enough that one is likely to form solid habits. That said, I can't think of a way to rephrase things so it can be Yes or No, so we might just have to live with this.

For consistency, add-ons should be spelled add-ons; note the hyphen. This occurs in your exit dialog, your changes to the Add-ons Manager and your User Guide changes.

The option "Show exit options on exiting NVDA" should probably be "Show exit options when exiting NVDA".

+++ b/source/gui/__init__.py
@@ -677,6 +673,51 @@ class LauncherDialog(wx.Dialog):
...
+     actionsLabel=wx.StaticText(self,-1,label=_("What to &do:"))
+     actionSizer.Add(actionsLabel)
+     actionsListID=wx.NewId()

I know we do this a lot in our existing code, but for future reference, you don't actually need to specify the id; it defaults to -1. You can just skip that and use the label keyword argument for the label. Same goes for wx.NewId; you almost never need ids now.
I'd prefer this was a question; e.g. "What would you like to &do?"

+     self.actions = [

nit: Probably doesn't need to be saved on self, since you never use it again.
You could even just do this in the call to construct actionsList, indenting the items one level. I'll leave this up to you, though.

+     self.actionsList=wx.Choice(self,actionsListID,name=_("Action"),choices=self.actions)

nit: The name argument isn't really used for anything, so I'd just remove it.

+++ b/source/gui/addonGui.py
@@ -29,6 +30,11 @@ class AddonsDialog(wx.Dialog):
...
+         addonsDisabledSizer=wx.BoxSizer(wx.VERTICAL)
+         addonsDisabledLabel=wx.StaticText(self,-1,label=_("All addons are now disabled. To enable addons you must restart NVDA."))

nit: There's no need for a sizer if it only contains one item and it's inside another sizer.

+++ b/source/nvda.pyw
@@ -75,6 +75,7 @@ parser.add_option('-l','--log-level',type="int",dest='logLevel',default=0,help="
...
+parser.add_option('--disable-addons',action="store_true",dest='disableAddons',default=False,help="Addons will have no effect")

Change the help message to "Disable all add-ons" or similar.

User Guide changes:

Every sentence should be on a separate line. There are a few cases where there are two sentences on the same line.
nvda -q -m won't actually silently exit the current copy. -m only applies to the newly started copy (if any).
Regarding the info about combining short options, I wonder whether this is really necessary. That's pretty standard for command line parsers.
I don't think the command line options should go in the Key Commands reference (remove %kc:*Include).
The --launcher option is really only meant for internal use and probably shouldn't be documented. This is also partly true for --secure, but there's no other way to disable the Python console right now, so we'll leave it for now.

Thanks again!

Uh oh!

add restart option to the exit dialog #4057

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions