Skip to content

Error extracting add-on when files inside the add-on hahve non-ASCII characters #2505

Description

@nvaccessAuto

Reported by ragb on 2012-07-02 13:38
This is more of python 2 and unicode terror stories...

When we extract the contects of an Add-on, the zipfile module can't handle file names with non-ASCII characteres. In fact, the zip format doesn't define any specific encoding for files.

The only solution is to extract manually the zipfile contents, decoding paths

I attach here the patch with the changes. Shall I commit it?
I use cp437 (dos-latine) to decode paths, because it seems what winzip and windows assume, according to the python docs.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Addon/managementIn NVDA management of addons by users.bug

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions