-
-
Notifications
You must be signed in to change notification settings - Fork 842
Make louisHelper the single point of liblouis interaction #20600
Copy link
Copy link
Labels
audience/nvda-devPR or issue is relevant to NVDA / Add-on developersPR or issue is relevant to NVDA / Add-on developersp5https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Description
Activity
Metadata
Metadata
Assignees
Labels
audience/nvda-devPR or issue is relevant to NVDA / Add-on developersPR or issue is relevant to NVDA / Add-on developersp5https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Related issues, PRs or discussions
Related to the braille/brailleInput package refator
What is the current state of the codebase?
Calls to the
louismodule are scattered throughout the braille and braille.input modules.Why are changes required?
louismodule. This makes it easier to react on changes in the louis module, since that module has a three months release cadence that doesn't follow NVDA"s API breakage path.What technical changes are required?
Replace all calls to
louiswith calls tolouisHelperand let that calllouis.Are the proposed technical changes API breaking?
Unknown
Are there potential risks or issues with the proposed implementation?
No