Report descriptions for .NET Framework WinForms ToolStrip menu items using UIA - #20486
Merged
SaschaCowley merged 5 commits intoJul 28, 2026
Merged
Conversation
cary-rowen
force-pushed
the
fix-winforms-menuitem-description
branch
from
July 11, 2026 21:36
39417af to
d864a96
Compare
cary-rowen
marked this pull request as ready for review
July 11, 2026 23:07
Collaborator
|
I don't think you need testing on older versions than .NET Framework 4.8. Pretty sure that it was already bundled with Windows 10. And I believe that the most recnet version of the framework is automatically targeted by applications anyway. |
seanbudd
added
the
conceptApproved
…item-description # Conflicts: # source/NVDAObjects/UIA/__init__.py # tests/unit/test_NVDAObjects_UIA.py # user_docs/en/changes.md
# Conflicts: # user_docs/en/changes.md
SaschaCowley
approved these changes
Jul 27, 2026
SaschaCowley
enabled auto-merge (squash)
July 27, 2026 06:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
No issue. This was found while investigating #19335 and is separate from #20485.
Summary of the issue:
Classic .NET Framework Windows Forms ToolStrip menu items exposed through the native UIA provider can expose
AccessibleDescriptiononly through LegacyIAccessible. UIAFullDescriptionandHelpTextare empty, so NVDA does not report the description.Description of user facing changes:
NVDA now reports object descriptions for affected ToolStrip menu items.
Description of developer facing changes:
No public API changes.
Description of development approach:
Extend the existing UIA menu item description handling with a LegacyIAccessible description fallback. Standard UIA descriptions remain preferred. For affected .NET Framework WinForms
ToolStripMenuItemproviders, the fallback is used only when the standard description is missing or equals the object name. Descriptions equal to the name remain suppressed.The fix is implemented directly in
NVDAObjects.UIA.MenuItem. Cached UIA framework and provider metadata are used to limit the fallback to the affected .NET Framework WinFormsToolStripMenuItemproviders, avoiding LegacyIAccessible queries for unrelated UIA menu items.Testing strategy:
Known issues with pull request:
None known.
Code Review Checklist: