Skip to content

Commit be9065a

Browse files
CyrilleB79CyrilleB79
authored
Fixes the announcement of cell formatting commands in Excel (#15527)
Fixes #15506 Fix-up of #14923 Summary of the issue: When peforming tests for #14923, I have wrongly assumed that Excel cell formatting shortcuts were control+shift+2/3/4/5. This assumption was based on my tests with Excel's interface changed to English on my system. However, it seems that the keyboard layout when Excel is started has also an impact on the shortcuts containing digits (see discussion in #14923). The actual shortcuts are control+2/3/4/5, as described in Microsoft documentation and as confirmed starting Excel with English GUI and English keyboard layout. Description of user facing changes On English systems (and probably many others), Excel cell formatting shortcuts control+2/3/4/5 will have their effect reported correctly. shift+control+2/3/4/5 will not report inappropriately formatting information on English systems. Description of development approach Modified the gesture definition.
1 parent 98cdc49 commit be9065a

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

‎source/NVDAObjects/window/excel.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1098,7 +1098,7 @@ def _toggleBooleanAttribute(self, gesture, getStateFun, msgOff, msgOn):
10981098
ui.message(msgOff)
10991099

11001100
@script(
1101-
gestures=["kb:control+b", "kb:control+shift+2"],
1101+
gestures=["kb:control+b", "kb:control+2"],
11021102
canPropagate=True,
11031103
)
11041104
def script_toggleBold(self, gesture):
@@ -1112,7 +1112,7 @@ def script_toggleBold(self, gesture):
11121112
)
11131113

11141114
@script(
1115-
gestures=["kb:control+i", "kb:control+shift+3"],
1115+
gestures=["kb:control+i", "kb:control+3"],
11161116
canPropagate=True,
11171117
)
11181118
def script_toggleItalic(self, gesture):
@@ -1126,7 +1126,7 @@ def script_toggleItalic(self, gesture):
11261126
)
11271127

11281128
@script(
1129-
gestures=["kb:control+u", "kb:control+shift+4"],
1129+
gestures=["kb:control+u", "kb:control+4"],
11301130
canPropagate=True,
11311131
)
11321132
def script_toggleUnderline(self, gesture):
@@ -1140,7 +1140,7 @@ def script_toggleUnderline(self, gesture):
11401140
)
11411141

11421142
@script(
1143-
gesture="kb:control+shift+5",
1143+
gesture="kb:control+5",
11441144
canPropagate=True,
11451145
)
11461146
def script_toggleStrikethrough(self, gesture):

‎user_docs/en/changes.t2t‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ There's also been bug fixes for the Add-on Store, Microsoft Office, Microsoft Ed
6767
- Microsoft Office:
6868
- Fixed crash in Microsoft Word when Document formatting options "report headings" and "report comments and notes" were not enabled. (#15019)
6969
- In Word and Excel, text alignment will be correctly reported in more situations. (#15206, #15220)
70+
- Fixes the announcement of some cell formatting shortcuts in Excel. (#15527)
7071
-
7172
- Microsoft Edge:
7273
- NVDA will no longer jump back to the last browse mode position when opening the context menu in Microsoft Edge. (#15309)

0 commit comments

Comments
 (0)