Skip to content

Commit af0e998

Browse files
LeonarddeRLeonarddeR
authored
Send architecture when update checking (#14019)
Summary of the issue: It was discovered in #12064 that NVDA sends the architecture to the update server when updating, but it doesn't properly distinguish between architectures. Therefore, NVDA should send which architecture is in use specifically. Description of user facing changes None, only for usage stats. Description of development approach Consistency of data is kept by not changing how the x64 key is determined in the dictionary. The specific architecture is added as an extra key to the dictionary.
1 parent f71c232 commit af0e998

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

‎source/updateCheck.py‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,11 @@ def checkForUpdate(auto: bool = False) -> Optional[Dict]:
119119
"version": versionInfo.version,
120120
"versionType": versionInfo.updateVersionType,
121121
"osVersion": winVersionText,
122+
# Check if the architecture is the most common: "AMD64"
123+
# Available values of PROCESSOR_ARCHITEW6432 found in:
124+
# https://docs.microsoft.com/en-gb/windows/win32/winprog64/wow64-implementation-details
122125
"x64": os.environ.get("PROCESSOR_ARCHITEW6432") == "AMD64",
126+
"osArchitecture": os.environ.get("PROCESSOR_ARCHITEW6432"),
123127
}
124128
if auto and allowUsageStats:
125129
synthDriverClass = synthDriverHandler.getSynth().__class__

‎user_docs/en/changes.t2t‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ What's New in NVDA
1111
- Desktop: ``shift+numpad2``.
1212
- Laptop: ``NVDA+ctrl+shift+.``.
1313
-
14-
- Introduced new commands to move the review cursor by page where supported by the application.
14+
- Introduced new commands to move the review cursor by page where supported by the application. (#14021)
1515
- Move to previous page:
1616
- Desktop: ``NVDA+pageUp``.
1717
- Laptop: ``NVDA+shift+pageUp``.
@@ -25,6 +25,8 @@ What's New in NVDA
2525

2626

2727
== Changes ==
28+
- NVDA now includes the architecture of the operating system as part of user statistics tracking. (#14019)
29+
-
2830

2931

3032
== Bug Fixes ==

0 commit comments

Comments
 (0)