Skip to content

Commit 2bfc3c2

Browse files
michaelDCurranmichaelDCurran
authored
UIA focus event handler: make sure to return if an NVDAObject could not be created. (#14314)
Fixes regression introduced in pr #14256 Summary of the issue: Sometimes a UIA focus event handler can't create an NVDAObject for the element being focused. Normally, in this situation, the event would be silently dropped. However, with the introduction of extra debugging for UIA events in pr #14256, a return was accidently removed, which meant that the shouldAllowUIAFocusEvent attribute tried to be looed up on the None (failed NVDAObject). This caused a noisy traceback in the log at level error. Description of user facing changes A noisy error traceback is no longer produced when NVDA cannot handle certain broken UIA focus events. Description of development approach Make sure to return if instantiating the NVDAObject produces None.
1 parent e4305a4 commit 2bfc3c2

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

‎source/UIAHandler/__init__.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -860,6 +860,7 @@ def IUIAutomationFocusChangedEventHandler_HandleFocusChangedEvent(self,sender):
860860
log.debug(
861861
"handleFocusChangedEvent: Could not create an NVDAObject "
862862
)
863+
return
863864
if _isDebug():
864865
log.debug(f"Created object {obj} for element {self.getUIAElementDebugString(sender)}")
865866
if not obj.shouldAllowUIAFocusEvent:

0 commit comments

Comments
 (0)