Skip to content

Add support for sys.monitoring events. #9482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 8 commits into from
Apr 26, 2024
Merged

Add support for sys.monitoring events. #9482

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7a19e9a
Add support for `sys.monitoring` events.
stuartarchibald Feb 16, 2024
4f870eb
Add support for RAISE and PY_UNWIND events.
stuartarchibald Apr 19, 2024
88c224a
Merge 'main' into wip/sys_monitoring
stuartarchibald Apr 22, 2024
0899844
Fix RST preference for underlining of headers.
stuartarchibald Apr 22, 2024
28ca083
Fix cProfile for Python < 3.11 when numba raises.
stuartarchibald Apr 24, 2024
3a17c60
Fix RST syntax in sys.monitoring docs.
stuartarchibald Apr 24, 2024
5d652e7
Workaround potential CPython bug.
stuartarchibald Apr 26, 2024
25535b3
Fix comment to read more clearly.
stuartarchibald Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions numba/tests/test_sys_monitoring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import dis
import functools
import queue
import sys
import threading
Expand All @@ -11,7 +10,6 @@
from numba.core.serialize import _numba_unpickle


@functools.cache
def generate_usecase():
@jit('int64(int64)',)
def foo(x):
Expand Down Expand Up @@ -285,6 +283,14 @@ def test_disable_from_callback(self):
self.assertEqual(result, self.call_foo_result)
callback.assert_called()
finally:
# It is necessary to restart events that have been disabled. The
# "disabled" state of the `PY_START` event for the tool
# `self.tool_id` "leaks" into subsequent tests. These tests then end
# up failing as events that should trigger do not! It's not really

@sklam sklam Apr 26, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

            # up failing as events that should trigger do not! It's not really
                                                      ^^^^^^^

you mean that should not trigger?

@stuartarchibald stuartarchibald Apr 26, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is trying to convey that "subsequent tests fail as events in them that should be triggered are not being triggered" (this was why the Mock.call_count value was 1 too small, an event that should have triggered did not).

@sklam sklam Apr 26, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My english parser segfaulted when reading it.

@stuartarchibald stuartarchibald Apr 26, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to make this comment more clear in 25535b3. Please take a look and see what you think. Thanks!

# clear why this happens, if it is part of the design or a side
# effect of the design, or if this behaviour is simply a bug in
# CPython itself.
sys.monitoring.restart_events()
sys.monitoring.register_callback(tool_id, event, None)
sys.monitoring.set_events(tool_id, NO_EVENTS)
sys.monitoring.free_tool_id(tool_id)
Expand Down