Skip to content

adding -pthread for linux-ppc64le in setup.py #8158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 6 commits into from
Aug 12, 2022
Merged

adding -pthread for linux-ppc64le in setup.py #8158

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fbd5df2
adding -pthread for linux-ppc64le in setup.py
esc Jun 14, 2022
46ad6ce
fix usage of extra_link args with -pthread
esc Jun 21, 2022
dd33b3d
include note about which c file needs pthreads
esc Jul 20, 2022
b57f404
Merge branch 'main' into build/ppc64le/add_pthread_to_setup.py
esc Jul 21, 2022
5646137
OpenMP does not need pthreads
esc Jul 21, 2022
b17fe1a
fix typo
esc Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,12 @@ def run(self):
cmdclass = versioneer.get_cmdclass()
cmdclass['build_doc'] = build_doc

extra_link_args = []
install_name_tool_fixer = []
if sys.platform == 'darwin':
install_name_tool_fixer += ['-headerpad_max_install_names']
if platform.machine() == 'ppc64le':
extra_link_args += ['-pthread']

build_ext = cmdclass.get('build_ext', build_ext)

Expand Down Expand Up @@ -172,7 +175,8 @@ def get_ext_modules():
"numba/cext/dictobject.c",
"numba/cext/listobject.c",
],
extra_link_args=install_name_tool_fixer,
extra_link_args=install_name_tool_fixer +
extra_link_args,
Comment thread
esc marked this conversation as resolved.
Resolved
depends=["numba/_pymodule.h",
"numba/_helperlib.c",
"numba/_lapack.c",
Expand Down Expand Up @@ -278,6 +282,7 @@ def check_file_at_path(path2file):
depends=['numba/np/ufunc/workqueue.h'],
include_dirs=[os.path.join(tbb_root, 'include')],
extra_compile_args=cpp11flags,
extra_link_args=extra_link_args,

@stuartarchibald stuartarchibald Jun 22, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed for TBB pool but not OpenMP one? Am guessing the pthread_atfork call in TBB and no pthread.h API use in OpenMP (even though the header file is #included

numba/numba/np/ufunc/omppool.cpp

Line 21 in 9a7820c

#include <pthread.h>
probably from adding debug code during development, e.g. calls to pthread_self()).

@esc esc Jul 4, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the OpenMP extension does not appear to need the linker flags.

@stuartarchibald stuartarchibald Jul 4, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking. I suggest removing the unused header as well as the use of the link time flags.

@esc esc Jul 21, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the header in 5646137

libraries=['tbb'], # TODO: if --debug or -g, use 'tbb_debug'
library_dirs=[
# for Linux
Expand Down Expand Up @@ -319,7 +324,8 @@ def check_file_at_path(path2file):
name='numba.np.ufunc.workqueue',
sources=['numba/np/ufunc/workqueue.c',
'numba/np/ufunc/gufunc_scheduler.cpp'],
depends=['numba/np/ufunc/workqueue.h'])
depends=['numba/np/ufunc/workqueue.h'],
extra_link_args=extra_link_args)
ext_np_ufunc_backends.append(ext_np_ufunc_workqueue_backend)
Comment thread
esc marked this conversation as resolved.
Resolved

ext_mviewbuf = Extension(name='numba.mviewbuf',
Expand Down