Skip to content

Fix scheduler bug where it rounds to 0 divisions for a chunk. #6760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 4 commits into from
Mar 2, 2021
Merged

Fix scheduler bug where it rounds to 0 divisions for a chunk. #6760

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0174b9c
Fix scheduler bug where it rounds to 0 divisions for a chunk.
DrTodd13 Feb 25, 2021
b2f1023
Add test for issue6749.
DrTodd13 Feb 25, 2021
7ec4753
Update numba/np/ufunc/gufunc_scheduler.cpp
DrTodd13 Feb 25, 2021
03101ac
Update numba/tests/test_parfors.py
DrTodd13 Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions numba/np/ufunc/gufunc_scheduler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,9 @@ void divide_work(const RangeActual &full_iteration_space,
} else {
// We allocate the remaining threads proportionally to the ratio of the current dimension length to the total.
divisions_for_this_dim = intp(guround(num_threads * ((float)dims[index].length / total_len)));
if (divisions_for_this_dim < 1) {
divisions_for_this_dim = 1;
}
}

// These are used to divide the iteration space.
Expand Down
8 changes: 8 additions & 0 deletions numba/tests/test_parfors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1839,6 +1839,14 @@ def test_impl(a):
x = np.ones((3,3))
self.check(test_impl, x)

@skip_parfors_unsupported
def test_high_dimension1(self):
# issue6749
def test_impl(x):
return x * 1.0
Comment thread
DrTodd13 marked this conversation as resolved.
Resolved
x = np.ones((2, 2, 2, 2, 2, 15))
self.check(test_impl, x)


class TestParforsLeaks(MemoryLeakMixin, TestParforsBase):
def check(self, pyfunc, *args, **kwargs):
Expand Down