Skip to content

Commit 2c1dce2

Browse files
swap357Kilo
andcommitted
add comments explaining NumPy<1.25 sincos test skips
Co-authored-by: Kilo <kilo@kilo.ai>
1 parent aa498c1 commit 2c1dce2

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

‎numba/tests/test_looplifting.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -534,6 +534,7 @@ def foo(x, y):
534534
# Ensure that is really a new overload for the lifted loop
535535
self.assertEqual(len(lifted.signatures), 2)
536536

537+
# Repeated sin/cos in this loop lets NumPy<1.25 error grow past ULP tolerance.
537538
@unittest.skipIf(numpy_sincos_low_precision,
538539
"NumPy<1.25 sincos vs libm")
539540
def test_lift_objectmode_issue_4223(self):

‎numba/tests/test_np_functions.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5732,6 +5732,7 @@ def test_select_exception(self):
57325732
np_nbfunc(condlist, choicelist, default)
57335733
self.assertIn(expected_text, str(e.exception))
57345734

5735+
# Near-zero window endpoints differ in sign under NumPy<1.25 sincos.
57355736
@unittest.skipIf(numpy_sincos_low_precision,
57365737
"NumPy<1.25 sincos vs libm")
57375738
def test_windowing(self):

0 commit comments

Comments
 (0)