Skip to content

Commit c7c56d8

Browse files
FrozenPandaznx-cloud[bot]
FrozenPandaz
and
nx-cloud[bot]
committed
chore(core): bump detect-port from ^1.5.1 to ^2.1.0 (#35533)
## Current Behavior `@nx/web`, `@nx/js`, and `@nx/cypress` declare `detect-port: ^1.5.1`. Per the bulk-dependency-update sweep (NXC-4329), this is due for a major bump. The queue task initially flagged this as ESM-only — that was stale info; v2 is actually dual-published. ## Expected Behavior Bumped to `detect-port@^2.1.0`. ## Validation `detect-port@2.1.0` ships both ESM and CJS builds via the package.json exports map: ```jsonc { "type": "module", "main": "./dist/commonjs/index.js", "exports": { ".": { "import": { "types": "./dist/esm/index.d.ts", "default": "./dist/esm/index.js" }, "require": { "types": "./dist/commonjs/index.d.ts", "default": "./dist/commonjs/index.js" } } }, "engines": { "node": ">= 16.0.0" } } ``` The three call sites in this repo: ```ts // packages/web/src/executors/file-server/file-server.impl.ts const detectPort = require('detect-port'); // CJS path // packages/js/src/executors/verdaccio/verdaccio.impl.ts import detectPort from 'detect-port'; // compiles to require → CJS // packages/cypress/src/utils/start-dev-server.ts import detectPort from 'detect-port'; // compiles to require → CJS ``` All three resolve to `./dist/commonjs/index.js` — no code changes needed. The default-export function shape (`detect(port, callback?) → Promise<number>`) is unchanged across v1 → v2. `pnpm nx run-many -t build -p web,js,cypress` — passes. ## Related Issue(s) Part of [NXC-4329](https://linear.app/nxdev/issue/NXC-4329) bulk-dependency-update sweep. --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com> Co-authored-by: FrozenPandaz <FrozenPandaz@users.noreply.github.com>
1 parent d64c172 commit c7c56d8

6 files changed

Lines changed: 28 additions & 13 deletions

File tree

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@
191191
"cytoscape-popper": "^2.0.0",
192192
"cz-git": "^1.4.0",
193193
"czg": "^1.4.0",
194-
"detect-port": "^1.5.1",
194+
"detect-port": "^2.1.0",
195195
"dotenv": "~16.4.5",
196196
"dotenv-expand": "~12.0.3",
197197
"ejs": "5.0.1",

‎packages/cypress/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"@nx/eslint": "workspace:*",
4242
"@nx/js": "workspace:*",
4343
"@phenomnomnominal/tsquery": "catalog:typescript",
44-
"detect-port": "^1.5.1",
44+
"detect-port": "^2.1.0",
4545
"semver": "catalog:",
4646
"tree-kill": "1.2.2",
4747
"tslib": "catalog:typescript"

‎packages/js/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
"babel-plugin-transform-typescript-metadata": "^0.3.1",
4949
"chalk": "catalog:",
5050
"columnify": "^1.6.0",
51-
"detect-port": "^1.5.1",
51+
"detect-port": "^2.1.0",
5252
"ignore": "^7.0.5",
5353
"js-tokens": "^4.0.0",
5454
"jsonc-parser": "3.2.0",

‎packages/web/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"migrations": "./migrations.json"
3333
},
3434
"dependencies": {
35-
"detect-port": "^1.5.1",
35+
"detect-port": "^2.1.0",
3636
"http-server": "^14.1.0",
3737
"picocolors": "catalog:",
3838
"tslib": "catalog:typescript",

‎packages/web/src/executors/file-server/file-server.impl.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { readModulePackageJson } from 'nx/src/utils/package-json';
1515
import { daemonClient } from 'nx/src/daemon/client/client';
1616
import { interpolate } from 'nx/src/tasks-runner/utils';
1717
import { stripGlobToBaseDir } from '@nx/js/src/utils/strip-glob-to-base-dir';
18-
const detectPort = require('detect-port');
18+
import detectPort from 'detect-port';
1919

2020
// platform specific command name
2121
const pmCmd = platform() === 'win32' ? `npx.cmd` : 'npx';

‎pnpm-lock.yaml‎

Lines changed: 23 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)