Cannot read nested array in bencode #13

Activity

1. Kineolyan commented on Nov 7, 2021

   

   Kineolyan

   on Nov 7, 2021

   Author

   More actions

   A quick check showed that this is not an issue for nested maps.
2. Kineolyan commented on Nov 9, 2021

   

   Kineolyan

   on Nov 9, 2021

   Author

   More actions

   So, after investigating this issue, I found some magic performed in the test: the function <bytes. As I understand it, it transforms the raw bytes that were decoded into beautiful UTF-8 strings. As I am writing this, it seems completely legit, because the string can have any charset.

   Though I just discovered this library, I would say that converting every byte-array to an original string form is quite common. I would gladly appreciate a nice utility function to convert all those bytes to string, using a custom function.
   I see that it applies to both bencode and netstring.
   What do you think?

   bencode/test/bencode/core_test.clj

   Lines 23 to 41 in 4286cee

   	(defmulti #^{:private true} <bytes class)
   	(defmethod <bytes :default
   	[input]
   	input)
   	(defmethod <bytes (RT/classForName "[B")
   	[#^"[B" input]
   	(String. input "UTF-8"))
   	(defmethod <bytes clojure.lang.IPersistentVector
   	[input]
   	(vec (map <bytes input)))
   	(defmethod <bytes clojure.lang.IPersistentMap
   	[input]
   	(->> input
   	(map (fn [[k v]] [k (<bytes v)]))
   	(into {})))