Build failures on Windows with 5.7-lkgr

CI run: https://ci.nodejs.org/job/node-compile-windows/7129/

Errors:

     Creating library c:\workspace\node-compile-windows\label\win-vs2015\Release\mksnapshot.lib and object c:\workspace\node-compile-windows\label\win-vs2015\Release\mksnapshot.exp
v8_base_1.lib(parser.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::FunctionForId(enum v8::internal::Runtime::FunctionId)" (?FunctionForId@Runtime@internal@v8@@SAPEBUFunction@123@W4FunctionId@123@@Z) [c:\workspace\node-compile-windows\label\win-vs2015\deps\v8\src\mksnapshot.vcxproj]
v8_base_1.lib(parser.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::FunctionForName(unsigned char const *,int)" (?FunctionForName@Runtime@internal@v8@@SAPEBUFunction@123@PEBEH@Z) [c:\workspace\node-compile-windows\label\win-vs2015\deps\v8\src\mksnapshot.vcxproj]
v8_base_3.lib(assembler.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::RuntimeFunctionTable(class v8::internal::Isolate *)" (?RuntimeFunctionTable@Runtime@internal@v8@@SAPEBUFunction@123@PEAVIsolate@23@@Z) [c:\workspace\node-compile-windows\label\win-vs2015\deps\v8\src\mksnapshot.vcxproj]
v8_base_3.lib(assembler.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::FunctionForEntry(unsigned char *)" (?FunctionForEntry@Runtime@internal@v8@@SAPEBUFunction@123@PEAE@Z) [c:\workspace\node-compile-windows\label\win-vs2015\deps\v8\src\mksnapshot.vcxproj]
v8_base_0.lib(js-operator.obj) : error LNK2001: unresolved external symbol "class std::basic_ostream<char,struct std::char_traits<char> > & __cdecl v8::internal::operator<<(class std::basic_ostream<char,struct std::char_traits<char> > &,enum v8::internal::Runtime::FunctionId)" (??6internal@v8@@YAAEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@AEAV23@W4FunctionId@Runtime@01@@Z) [c:\workspace\node-compile-windows\label\win-vs2015\deps\v8\src\mksnapshot.vcxproj]
c:\workspace\node-compile-windows\label\win-vs2015\Release\mksnapshot.exe : fatal error LNK1120: 5 unresolved externals [c:\workspace\node-compile-windows\label\win-vs2015\deps\v8\src\mksnapshot.vcxproj]

/cc @nodejs/v8

Confirmed in a new run: https://ci.nodejs.org/job/node-compile-windows/7432/
/cc @nodejs/platform-windows

@joaocgreis

@joaocgreis FYI this issue is fixed in V8 master. I don't know what commit fixed it.

The error disappears with this commit: v8@3297130.

Confirmed: https://ci.nodejs.org/job/node-test-commit/8640/

This was fixed for x64, but possibly never tested on x86. Now, x86 builds are failing (nodejs/build#669), the V8 update seems to be the root cause (still unconfirmed but the timing matches). The console output is similar:

     Creating library c:\ws\Release\mksnapshot.lib and object c:\ws\Release\mksnapshot.exp
v8_base_0.lib(parser.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::FunctionForId(enum v8::internal::Runtime::FunctionId)" (?FunctionForId@Runtime@internal@v8@@SAPBUFunction@123@W4FunctionId@123@@Z) [c:\ws\deps\v8\src\mksnapshot.vcxproj]
v8_base_0.lib(parser.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::FunctionForName(unsigned char const *,int)" (?FunctionForName@Runtime@internal@v8@@SAPBUFunction@123@PBEH@Z) [c:\ws\deps\v8\src\mksnapshot.vcxproj]
v8_base_3.lib(assembler.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::RuntimeFunctionTable(class v8::internal::Isolate *)" (?RuntimeFunctionTable@Runtime@internal@v8@@SAPBUFunction@123@PAVIsolate@23@@Z) [c:\ws\deps\v8\src\mksnapshot.vcxproj]
v8_base_3.lib(assembler.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::FunctionForEntry(unsigned char *)" (?FunctionForEntry@Runtime@internal@v8@@SAPBUFunction@123@PAE@Z) [c:\ws\deps\v8\src\mksnapshot.vcxproj]
v8_base_0.lib(js-operator.obj) : error LNK2001: unresolved external symbol "class std::basic_ostream<char,struct std::char_traits<char> > & __cdecl v8::internal::operator<<(class std::basic_ostream<char,struct std::char_traits<char> > &,enum v8::internal::Runtime::FunctionId)" (??6internal@v8@@YAAAV?$basic_ostream@DU?$char_traits@D@std@@@std@@AAV23@W4FunctionId@Runtime@01@@Z) [c:\ws\deps\v8\src\mksnapshot.vcxproj]
c:\ws\Release\mksnapshot.exe : fatal error LNK1120: 5 unresolved externals [c:\ws\deps\v8\src\mksnapshot.vcxproj]

The same commit that fixes this for x64 breaks for x86. I was able to confirm that this is because the change of position in v8.gyp, moving those 3 lines to the old position fixes this issue for x86.

deps,win: increase msvs_shard in gyp for V8

deps,win: set MSVS .obj folders in gyp for V8

deps,win: increase msvs_shard in gyp for V8

A fix for this issue landed on V8 upstream.
Original PR: nodejs/node#13959
V8's Code Review: https://chromium-review.googlesource.com/c/556599/
V8's Commit: https://chromium.googlesource.com/v8/v8/+/3bef2af6ef198b0cd1342680bf5d7d782dc71a46

Navigation Menu

Repository navigation

Build failures on Windows with 5.7-lkgr #4

75 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Build failures on Windows with 5.7-lkgr #4

Description

Activity

targos commented on Mar 8, 2017

targos commented on Mar 21, 2017

targos commented on Mar 23, 2017

targos commented on Mar 23, 2017

joaocgreis commented on Mar 30, 2017

joaocgreis commented on Mar 31, 2017

75 remaining items

jaimecbernardo commented on Jun 30, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions