Skip to content

Update workflow to check for conventional commit types #663

Open
Open
Update workflow to check for conventional commit types#663

Description

@anonrig
anonrig
opened on Dec 6, 2022

I recommend updating the pull request workflow to check for conventional commit format in the commits, since release changelog requires it.

If there's no objections, I'll be happy to add it.

https://www.conventionalcommits.org/en/v1.0.0/

Activity

  1. aduh95 commented on Dec 6, 2022

    @aduh95
    aduh95
    on Dec 6, 2022
    Contributor

    There's already https://github.com/nodejs/node-core-utils/blob/main/.github/workflows/commitlint.yml, what else do you have in mind?

  2. anonrig commented on Dec 6, 2022

    @anonrig
    anonrig
    on Dec 6, 2022
    MemberAuthor

    I need we need to also check the title of the pull request for conventional commit format in order to reduce the probability of failures on squashed pull requests with names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions