Skip to content

Commit 10c6f35

Browse files
authored
fix(git-node): fix SSH passphrase input when promoting a release (#1097)
1 parent eb405a1 commit 10c6f35

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

‎lib/promote_release.js‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { pipeline } from 'node:stream/promises';
55
import semver from 'semver';
66
import * as gst from 'git-secure-tag';
77

8-
import { forceRunAsync } from './run.js';
8+
import { forceRunAsync, runSync } from './run.js';
99
import PRData from './pr_data.js';
1010
import PRChecker from './pr_checker.js';
1111
import Session from './session.js';
@@ -59,7 +59,8 @@ export default class ReleasePromotion extends Session {
5959
if (!localCloneIsClean) {
6060
if (await cli.prompt('Should we checkout the release proposal?')) {
6161
cli.startSpinner('Fetching the proposal upstream...');
62-
await forceRunAsync('git', ['fetch', proposalUpstreamRemote, releaseCommitSha],
62+
// We need a sync spawn here to avoid the spinner getting in the way of SSH key passphrase
63+
runSync('git', ['fetch', proposalUpstreamRemote, releaseCommitSha],
6364
{ ignoreFailure: false });
6465
await forceRunAsync('git', ['checkout', releaseCommitSha], { ignoreFailure: false });
6566
cli.stopSpinner('Local HEAD is now in sync with the proposal');

0 commit comments

Comments
 (0)