Skip to content

cluster: replace forEach with for..of in lib/internal/cluster/ directory #50317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 5 commits into from
May 12, 2024
Merged

cluster: replace forEach with for..of in lib/internal/cluster/ directory #50317

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
001629e
cluster: replace forEach with for..of in lib/internal/cluster/ directory
jerome-benoit Oct 21, 2023
3deccf4
refactor: silence linter
jerome-benoit Oct 22, 2023
0b1f164
build: silence linter
jerome-benoit Oct 23, 2023
92a9ea3
fix: handles in a SafeMap
jerome-benoit Oct 23, 2023
6950c59
Update lib/internal/cluster/primary.js
jerome-benoit May 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/internal/cluster/child.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,14 +270,14 @@ function _disconnect(primaryInitiated) {
}
}

handles.forEach((handle) => {
for (const handle of handles.values()) {
waitingCount++;

if (handle[owner_symbol])
handle[owner_symbol].close(checkWaitingCount);
else
handle.close(checkWaitingCount);
});
}

handles.clear();
checkWaitingCount();
Expand Down
5 changes: 3 additions & 2 deletions lib/internal/cluster/primary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,11 @@ function removeWorker(worker) {
function removeHandlesForWorker(worker) {
assert(worker);

handles.forEach((handle, key) => {
// eslint-disable-next-line node-core/no-array-destructuring
for (const [key, handle] of handles) {
Comment thread
jerome-benoit marked this conversation as resolved.
Resolved
if (handle.remove(worker))
handles.delete(key);
});
}
}

cluster.fork = function(env) {
Expand Down