Skip to content

test: fix suite signal #47800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 7 commits into from
May 17, 2023
Merged

test: fix suite signal #47800

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0bafcf7
test: fix suite signal
May 1, 2023
10b3a0e
fixup!
benjamingr May 1, 2023
f7bb033
fixup! lint
benjamingr May 1, 2023
6412f51
fixup! lint
benjamingr May 1, 2023
57298d8
fixup! ai
benjamingr May 1, 2023
9f38158
Update lib/internal/test_runner/test.js
benjamingr May 2, 2023
0a0dc6e
fix
MoLow May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/internal/test_runner/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,8 +760,10 @@ class Suite extends Test {

try {
const { ctx, args } = this.getRunArgs();
const runArgs = ArrayPrototypeSlice(args);
ArrayPrototypeShift(runArgs, ctx);
Comment thread
benjamingr marked this conversation as resolved.
Resolved
this.buildSuite = PromisePrototypeThen(
PromiseResolve(this.runInAsyncScope(this.fn, ctx, args)),
PromiseResolve(ReflectApply(this.runInAsyncScope, this.fn, runArgs)),
Comment thread
MoLow marked this conversation as resolved.
Resolved
undefined,
(err) => {
this.fail(new ERR_TEST_FAILURE(err, kTestCodeFailure));
Expand Down
8 changes: 8 additions & 0 deletions test/parallel/test-runner-misc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@ if (process.argv[2] === 'child') {
})).finally(common.mustCall(() => {
test(() => assert.strictEqual(testSignal.aborted, true));
}));

// TODO(benjamingr) add more tests to describe + AbortSignal
// this just tests the parameter is passed
test.describe('Abort Signal in describe', common.mustCall(({ signal }) => {
test.it('Supports AbortSignal', () => {
assert.strictEqual(signal.aborted, false);
});
}));
} else assert.fail('unreachable');
} else {
const child = spawnSync(process.execPath, [__filename, 'child', 'abortSignal']);
Expand Down