Skip to content

src: ignore maybe-uninitialized warning string_search #31532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 3 commits into from
Closed

src: ignore maybe-uninitialized warning string_search #31532

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b520c74
src: ignore maybe-uninitialized warning string_search
danbev Jan 27, 2020
1b3454d
Revert "src: ignore maybe-uninitialized warning string_search"
danbev Feb 3, 2020
b1269ab
src: ignore maybe-uninitialized warning string_search
danbev Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/string_search.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,14 @@ class StringSearch : private StringSearchBase {
}

size_t Search(Vector subject, size_t index) {
#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
#endif
return (this->*strategy_)(subject, index);
#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic pop
#endif

@lundibundi lundibundi Jan 29, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC the issue is not with strategy_, but with the arrays in the StringSearchBase, which are indeed uninitialized (they will be initialized before BoyerMoore search is started)

@danbev danbev Feb 3, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lundibundi Thanks, I'll try to take a closer look at this again this week.

}

static inline int AlphabetSize() {
Expand Down