Skip to content

Update internal util isError with new Error.isError #57961

Closed as not planned

Description

@miguelmarcondesf

With Version 24.0.0 V8 will be updated to 13.4 and Error.isError will be available, with that we can update the way we check if an object is an error in some places.

Following @jasnell suggestion in @geeksilva97 PR #55406, I would like to start some issues regarding where this change is necessary, starting with the isError present in lib/internal/util

Activity

  1. ljharb commented on Apr 21, 2025

    @ljharb
    SponsorMember

    We should probably deprecate util.types.isNativeError as well as of v24?

  2. marco-ippolito commented on Apr 22, 2025

    @marco-ippolito
    Member

    I remember deprecating all the all the util.is functions.
    util.isError is in fact EOL
    https://nodejs.org/api/deprecations.html#DEP0048
    If its not used anywhere in the codebase it can be removed

  3. miguelmarcondesf commented on Apr 22, 2025

    @miguelmarcondesf
    ContributorAuthor

    I remember deprecating all the all the util.is functions. util.isError is in fact EOL https://nodejs.org/api/deprecations.html#DEP0048 If its not used anywhere in the codebase it can be removed

    You're right about that, but this one is related to isError from the internal helper.

  4. Renegade334 commented on May 2, 2025

    @Renegade334
    Member

    We should probably deprecate util.types.isNativeError as well as of v24?

    FWIW, I'm seeing a 50% performance regression for Error.isError over the current util/types IsNativeError binding in the latest build.

  5. github-actions commented on Apr 20, 2026

    @github-actions
    Contributor

    This issue has been marked as stale due to 210 days of inactivity.
    It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

  6. added
    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.
    on Apr 20, 2026
  7. github-actions commented on May 20, 2026

    @github-actions
    Contributor

    This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 240 days).
    If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions