Skip to content

doc: bad crypto.verify() dsaEncoding description #37454

Closed
Closed
doc: bad crypto.verify() dsaEncoding description#37454
Labels
cryptoIssues and PRs related to the crypto subsystem.docIssues and PRs related to Node.js documentation.good first issueIssues that are suitable for first-time contributors.

Description

@mscdex
mscdex
opened on Feb 20, 2021

📗 API Reference Docs Problem

  • Version: master
  • Platform: n/a
  • Subsystem: doc, crypto

Location

crypto.verify()

Affected URL(s):

Description

The description of dsaEncoding uses the term "generated signature" which is a bit confusing when the function is actually verifying an existing signature and may be a copy-paste error from crypto.sign().

  • I would like to work on this issue and
    submit a pull request.

Activity

  1. mscdex
    added
    cryptoIssues and PRs related to the crypto subsystem.
    docIssues and PRs related to Node.js documentation.
    good first issueIssues that are suitable for first-time contributors.
    on Feb 20, 2021
  2. mscdex
    changed the title [-]doc: [/-] [+]doc: bad `crypto.verify()` dsaEncoding description[/+] on Feb 20, 2021

  3. yagipy commented on Feb 20, 2021

    @yagipy
    yagipy
    on Feb 20, 2021

    I would like to work on this issue

  4. kaznovac commented on Feb 20, 2021

    @kaznovac
    kaznovac
    on Feb 20, 2021
    Contributor

    @HiroyukiYagihashi sorry i've already created a pr for this, you are welcome to review it

  5. khampret commented on Feb 26, 2021

    @khampret
    khampret
    on Feb 26, 2021

    What this issues?

  6. jasnell
    closed this as completedin 4947ce5on Mar 9, 2021

  7. vishalvikal commented on Mar 12, 2021

    @vishalvikal
    vishalvikal
    on Mar 12, 2021

    Hello there,
    Recently I build node locally on my setup. I also want to contribute to this project please any body tell me about this issue. What can I do with javaScript modules.

  8. danielleadams
    added a commit that references this issue on Mar 16, 2021

    doc: remove generated from dsaEncoding description

    6192315
  9. targos
    added 4 commits that reference this issue on May 27, 2021

    doc: remove generated from dsaEncoding description

    c95846d

    doc: remove generated from dsaEncoding description

    7c66142

    doc: remove generated from dsaEncoding description

    0d2704f

    doc: remove generated from dsaEncoding description

    a6c1233
  10. MayaLekova
    added a commit that references this issue on May 22, 2026

    doc: remove generated from dsaEncoding description

    4947ce5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cryptoIssues and PRs related to the crypto subsystem.docIssues and PRs related to Node.js documentation.good first issueIssues that are suitable for first-time contributors.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions