Repository navigation
querystring inconsistent behaviour #33910
Description
The module querystring presents odd behaviour and inconsistent across platforms.
On NodeJs v14.2 x86_64 GNU/Linux
Parsing an object with an empty array into a querystring yields & with no element.
const querystring = require('querystring')
> querystring.stringify({ a:2, b:[] })
'a=2&' // expected result --> a=2 or a=2&b=
On Firefox 77.0.1 (64-bit)
Yet, when using the module in a react application with client side rendering the result is as follows:
import querystring from 'querystring'
> querystring.stringify({ a:2, b:[] }) // 'a=2'
This issue can lead to some of the following malformed URLs which may fault some server parsers. (My experience was with WSGI server)
Activity
jasnell commentedon Jun 16, 2020
Note that the version running within Firefox is likely a browserified version that is derived from the Node.js version. That's a bit of a guess without seeing the code but it is possible for there to be differences in the way they are implemented. We do not provide support for browserified ports of the core modules.
sapics commentedon Jun 17, 2020
I guess that
a=2would be more expected one, becausequerystring.stringify({ a: [], b: [] })is empty string.I try to fix and make a PR.
sapics commentedon Jun 17, 2020
I create a PR #33918. There were some errors at early commit, now it is fixed.
If there are something I was missing or you have any additional information, I'd appreciate it if you make a comment here or PR ;)
scucchiero commentedon Jun 17, 2020
great job mate, that was pretty quick.
so far that is the only things that I caught.
I will make sure to post anything else me or my team notice.
targos commentedon Dec 27, 2020
Fixed by #33918