Repository navigation
MacOS build fails #33401
Description
MacOS builds fail on CI
Examples:
https://github.com/nodejs/node/pull/33395/checks?check_run_id=673915168
https://github.com/nodejs/node/pull/33396/checks?check_run_id=673650394
https://github.com/nodejs/node/pull/33399/checks?check_run_id=674009996
make[2]: *** [/Users/runner/runners/2.169.1/work/node/node/out/Release/obj.target/libnode/src/api/environment.o] Error 1
In file included from ../src/async_wrap.cc:23:
In file included from ../src/async_wrap-inl.h:29:
../src/node_internals.h:115:17: error: 'Reallocate' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
virtual void* Reallocate(void* data, size_t old_size, size_t size);
^
../deps/v8/include/v8.h:5064:19: note: overridden virtual function is here
virtual void* Reallocate(void* data, size_t old_length, size_t new_length);
^
1 error generated.
make[2]: *** [/Users/runner/runners/2.169.1/work/node/node/out/Release/obj.target/libnode/src/async_wrap.o] Error 1
rm 901e15e3bfa09076435ef2c6529c32d9b1b08dee.intermediate 4932d3b9aac55583abc688388403c323f0ca30f4.intermediate
make[1]: *** [node] Error 2
make: *** [build-ci] Error 2
The failure might be caused by this commit fcc183c. @richardlau is it OK that builds fail?
Activity
richardlau commentedon May 14, 2020
The failure is because after fcc183c warnings are being treated as errors for non-deps code. The non-deps code was warning free at the beginning of the week -- unfortunately the V8 8.3 update landing has introduced new warnings, such as the one above (unfortunate in the sense that the actions/CI runs for the V8 update happened before we switched on the
--errors-on-warnflag, the idea being that having the flag on would help prevent PRs landing that introduced new warnings).shackijj commentedon May 14, 2020
Can we do something apart from disabling
--errors-on-warnfor macOS and reverting V8 8.3 update?richardlau commentedon May 14, 2020
This might be fixed by #32716 (which landed on the V8 canary branch)? cc @gengjiawen
shackijj commentedon May 14, 2020
The quote above is from this guide. Is landing of PRs an automated process? If yes, can we somehow improve it as to avoid merging commits that don't pass CI test run?
gengjiawen commentedon May 14, 2020
Yeap, need to cherrypick to master.
gengjiawen commentedon May 14, 2020
It passed the CI, just not rebased to the latest. We always land commit with full
CI pass.
gengjiawen commentedon May 14, 2020
PR: #33402