You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
n-api: duplicated parameters on napi_open_callback_scope #32897
napi_open_callback_scope accepts an napi_value resource_object and another napi_async_context context, while an napi_async_context has to be created with an napi_value async_resource and its associated napi_value async_resource_name. In this case, napi_open_callback_scope can infer resource_object to the given napi_async_context.
Unfortunately, napi_async_context currently doesn't hold a reference to its async_resource. So napi_open_callback_scope is unable to access the resource_object too.
This also creates a potential conflict that which resource object should represent the executionAsyncResource of the napi_callback_scope.
Activity
gabrielschulhof commentedon Nov 13, 2020
This issue is addressed in #32930 via a documentation change, which has proven the only way to address without ABI breakage.