test: make parallel/test-bootstrap-modules easier to reason about

@addaleax

Version: N/A
Platform: All
Subsystem: test,bootstrap

node/test/parallel/test-bootstrap-modules.js

Lines 1 to 14 in 5468509

    
           /* eslint-disable node-core/required-modules */ 
        
           'use strict'; 
        
           // Ordinarily test files must require('common') but that action causes 
        
           // the global console to be compiled, defeating the purpose of this test. 
        
           // This makes sure no additional files are added without carefully considering 
        
           // lazy loading. Please adjust the value if necessary. 
        
           const list = process.moduleLoadList.slice(); 
        
           const assert = require('assert'); 
        
           assert(list.length <= 78, list);

The test uses a magic number that can only be reasonably found empeericaly. That number also changes depending on what CLI parameters are used, or if run with a test harness.
Some suggestions for improvement have been:

blacklist some modules that we know we don’t want to have loaded unconditionally, rather than set a fixed number. (@addaleax)
Just reports from the CI or add something informative to the test runner output. (@devsnek)
???

Refs: #23876

fwiw my suggestion is now a whitelist of modules

@refack

Can I work on this as this has a good first issue tag? @refack

I kind of wonder if the test should be removed.

Navigation Menu

Repository navigation

test: make `parallel/test-bootstrap-modules` easier to reason about #23884

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	/* eslint-disable node-core/required-modules */

	'use strict';

	// Ordinarily test files must require('common') but that action causes
	// the global console to be compiled, defeating the purpose of this test.
	// This makes sure no additional files are added without carefully considering
	// lazy loading. Please adjust the value if necessary.

	const list = process.moduleLoadList.slice();

	const assert = require('assert');

	assert(list.length <= 78, list);

test: make parallel/test-bootstrap-modules easier to reason about #23884

Description

Activity

devsnek commented on Oct 25, 2018

ho-dor commented on Nov 8, 2018

Trott commented on Nov 20, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

test: make `parallel/test-bootstrap-modules` easier to reason about #23884