Skip to content

test: help annotate test/parallel/test-util-log.js #22472

Closed
Closed
test: help annotate test/parallel/test-util-log.js#22472
Labels
good first issueIssues that are suitable for first-time contributors.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@refack
refack
opened on Aug 23, 2018

Help needed with some code archeology:
The test in node/test/parallel/test-util-log.js ends with common.restoreStdout(); but no common.restoreStderr();

node/test/parallel/test-util-log.js

Lines 58 to 60 in 6acb550

assert.strictEqual(process.stdout.writeTimes, tests.length);
common.restoreStdout();

We should have a comment documenting the reason why (or fix it).

Ref: #13439

Activity

  1. refack
    added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    good first issueIssues that are suitable for first-time contributors.
    on Aug 23, 2018

  2. abelmark commented on Aug 23, 2018

    @abelmark
    abelmark
    on Aug 23, 2018
    Contributor

    Submitted a pull request.

  3. addaleax
    closed this as completedin ed35df7on Sep 19, 2018
  4. targos
    added a commit that references this issue on Sep 20, 2018

    lib: added common.restoreStderr(); to end of file

    fb68ef2
  5. sjarmak
    added a commit that references this issue on Jul 27, 2026

    lib: added common.restoreStderr(); to end of file

    ed35df7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueIssues that are suitable for first-time contributors.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions