investigate flaky "sequential/test-http-server-consumed-timeout" #14312

Activity

1. Trott

   added

   flaky-testIssues and PRs involving tests that fail intermittently in CI.Issues and PRs involving tests that fail intermittently in CI.

   httpIssues and PRs related to the http subsystem.Issues and PRs related to the http subsystem.

   windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.

   on Jul 16, 2017
2. refack

   removed

   windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.

   on Aug 13, 2017
3. refack commented on Aug 13, 2017

   

   refack

   on Aug 13, 2017

   Last edited by refack

   Contributor

   More actions

   Showed up on linuxONE

   not ok 1661 sequential/test-http-server-consumed-timeout
     ---
     duration_ms: 0.559
     severity: fail
     stack: |-
       assert.js:42
         throw new errors.AssertionError({
         ^
       
       AssertionError [ERR_ASSERTION]: Request timeout should not fire
           at IncomingMessage.mustNotCall (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/common/index.js:560:12)
           at emitOne (events.js:115:13)
           at IncomingMessage.emit (events.js:210:7)
           at Socket.socketOnTimeout (_http_server.js:389:48)
           at emitNone (events.js:105:13)
           at Socket.emit (events.js:207:7)
           at Socket._onTimeout (net.js:400:8)
           at ontimeout (timers.js:469:11)
           at tryOnTimeout (timers.js:304:5)
           at Timer.listOnTimeout (timers.js:264:5)
     ...
   

   https://ci.nodejs.org/job/node-test-commit-linuxone/7940/nodes=rhel72-s390x/console

   Stress test indicate 0.1% failures - https://ci.nodejs.org/job/node-stress-single-test/1373/nodes=rhel72-s390x/
4. refack

   changed the title [-]investigate flaky sequential/test-http-server-consumed-timeout on Windows[/-] [+]investigate flaky "sequential/test-http-server-consumed-timeout"[/+] on Aug 13, 2017
5. BridgeAR commented on Sep 28, 2017

   

   BridgeAR

   on Sep 28, 2017

   Member

   More actions

   @nodejs/testing are we just going to live with the test being flaky at times?
6. Trott commented on Sep 29, 2017

   

   Trott

   on Sep 29, 2017

   MemberAuthor

   More actions

   Because there's always a chance that a 25ms timeout will take longer than 200ms to actually be invoked, there's always going to be a chance that this test (as written) will fail spuriously. However, I think I see a way to reduce the frequency by an order of magnitude or two...

   First, though, CI stress on current master to confirm we still have a measurable problem: https://ci.nodejs.org/job/node-stress-single-test/1427/nodes=rhel72-s390x/console
7. Trott

   added a commit that references this issue on Sep 29, 2017

   test: skip test if host is too slow

   ...

   f001398
8. Trott commented on Sep 29, 2017

   

   Trott

   on Sep 29, 2017

   MemberAuthor

   More actions

   OK, I'm able to get it to 100% reliability as long as we're OK with skipping the test in unfavorable conditions. See #15688

   👍React with 👍2Reacted by Refael Ackermann and Gibson Fahnestock
9. Trott

   added a commit that references this issue on Oct 4, 2017

   test: skip test if host is too slow

   ...

   a3cd8ed
10. Trott

    closed this as completedin a3cd8edon Oct 4, 2017
11. addaleax

    added a commit that references this issue on Oct 4, 2017

    test: skip test if host is too slow

    ...

    deeda3a
12. MylesBorins

    added 3 commits that reference this issue on Oct 7, 2017

    test: skip test if host is too slow

    ...

    1a0211a

    test: skip test if host is too slow

    ...

    995948a

    test: skip test if host is too slow

    ...

    019fa6c
13. MylesBorins

    added a commit that references this issue on Oct 25, 2017

    test: skip test if host is too slow

    ...

    83a2513