Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ff7d053ae6b7f620516049e5c9bd1b6ab348835f
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d17d7bdf4e3ba0e2458abcf8056e9b9ab824a04c
Choose a head ref
  • 2 commits
  • 6 files changed
  • 1 contributor

Commits on Dec 4, 2018

  1. src: move READONLY_* macros into util.h 

    Move these macros to util.h so they can be shared among different
C++ files.
Also, renames `READONLY_BOOLEAN_PROPERTY` to `READONLY_TRUE_PROPERTY`
(since it sets the property to true), and use `ToV8Value` in
`READONLY_STRING_PROPERTY`.

PR-URL: #24774
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @joyeecheung @Trott
    joyeecheung authored and Trott committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    7761881 View commit details
    Browse the repository at this point in the history

  2. src: move version metadata into node_metadata{.h, .cc} 

    This patch moves the computation of version metadata from node.cc
into node_metadata{.h, .cc}, and creates a macro that can be
used to iterate over the available version keys (v8, uv, .etc).
This makes the code clearer as now we no longer need to add
all the headers in node.cc just to compute the versions, and
makes it easier to reuse the version definitions.

PR-URL: #24774
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @joyeecheung @Trott
    joyeecheung authored and Trott committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    d17d7bd View commit details
    Browse the repository at this point in the history
Loading