Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f6f0b387eab735c49e0987020f5673950d5c9f91
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 62e83b363e01ac74faeb15aa1b5895d3c20d3bdd
Choose a head ref
  • 3 commits
  • 15 files changed
  • 3 contributors

Commits on Nov 22, 2016

  1. src: renaming ares_task struct to node_ares_task 

    This commit attempts to fix one of the items in
#4641, which was to remove a TODO
comment from env.h regarding the naming of the ares_task_t struct.

Also, the struct ares_task_list was renamed to node_ares_task_list
following the same reasoning that is does not belong to the c-ares API.

PR-URL: #7345
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @danbev Myles Borins
    danbev authored and Myles Borins committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    3b5cede View commit details
    Browse the repository at this point in the history

  2. src: normalize malloc, realloc 

    malloc(0) and realloc(ptr, 0) have implementation-defined behavior in
that the standard allows them to either return a unique pointer or a
nullptr for zero-sized allocation requests.  Normalize by always using
a nullptr.

- Introduce node::malloc, node::realloc and node::calloc that should
  be used throught our source.
- Update all existing node source files to use the new functions
  instead of the native allocation functions.

Fixes: #7549
PR-URL: #7564
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @mhdawson Myles Borins
    mhdawson authored and Myles Borins committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    51e09d0 View commit details
    Browse the repository at this point in the history

  3. src: Malloc/Calloc size 0 returns non-null pointer 

    Change `Malloc()/Calloc()` so that size zero does not return a null
pointer, consistent with prior behavior.

Fixes: #8571
PR-URL: #8572
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@keybase.io>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @Trott Myles Borins
    Trott authored and Myles Borins committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    62e83b3 View commit details
    Browse the repository at this point in the history
Loading