Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f5756d997b50053a45222db6658a4d593b26d3e2
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a3208bdaab04e6b949e4d6fbf550b45e128c3e10
Choose a head ref
  • 6 commits
  • 98 files changed
  • 2 contributors

Commits on Jul 11, 2016

  1. deps: upgrade libuv to 1.9.0 

    Fixes: #5737
Fixes: #4643
Fixes: #4291
Fixes: nodejs/node-v0.x-archive#8960
Refs: #3594
PR-URL: #5994
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    @saghul Myles Borins
    saghul authored and Myles Borins committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    50da0ae View commit details
    Browse the repository at this point in the history

  2. deps: upgrade libuv to 1.9.1 

    Fixes: #4002
Fixes: #5384
Fixes: #6563
Refs: #2680 (comment)
PR-URL: #6796
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @saghul Myles Borins
    saghul authored and Myles Borins committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    2713f7f View commit details
    Browse the repository at this point in the history

  3. unix,stream: fix getting the correct fd for a handle 

    On OSX it's possible that the fd is replaced, so use the proper libuv
API to get the correct fd.

PR-URL: #6753
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @saghul Myles Borins
    saghul authored and Myles Borins committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    2d93202 View commit details
    Browse the repository at this point in the history

  4. tty: use blocking mode on OS X 

    OS X has a tiny 1kb hard-coded buffer size for stdout / stderr to
TTYs (terminals). Output larger than that causes chunking, which ends
up having some (very small but existent) delay past the first chunk.
That causes two problems:

1. When output is written to stdout and stderr at similar times, the
two can become mixed together (interleaved). This is especially
problematic when using control characters, such as \r. With
interleaving, chunked output will often have lines or characters erased
unintentionally, or in the wrong spots, leading to broken output.
CLI apps often extensively use such characters for things such as
progress bars.

2. Output can be lost if the process is exited before chunked writes
are finished flushing. This usually happens in applications that use
`process.exit()`, which isn't infrequent.

See #6980 for more info.

This became an issue as result of the Libuv 1.9.0 upgrade. A fix to
an unrelated issue broke a hack previously required for the OS X
implementation. This resulted in an unexpected behavior change in node.
The 1.9.0 upgrade was done in c3cec1e,
which was included in v6.0.0.
Full details of the Libuv issue that induced this are at
#6456 (comment)

Refs: #1771
Refs: #6456
Refs: #6773
Refs: #6816
PR-URL: #6895
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Fishrock123 Myles Borins
    Fishrock123 authored and Myles Borins committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    e413ef3 View commit details
    Browse the repository at this point in the history

  5. udp: use libuv API to get file descriptor 

    Refs: #6838
PR-URL: #6908
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @saghul Myles Borins
    saghul authored and Myles Borins committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    9946b56 View commit details
    Browse the repository at this point in the history

  6. test: test TTY problems by fakeing a TTY using openpty 

    Many thanks to thefourtheye and addaleax who helped make the python
bits of this possible.

See #6980 for more info regarding
the related TTY issues.

Refs: #6456
Refs: #6773
Refs: #6816
PR-URL: #6895
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Fishrock123 Myles Borins
    Fishrock123 authored and Myles Borins committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    a3208bd View commit details
    Browse the repository at this point in the history
Loading