Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: efce655c0f1671d0e86b5c89092ac93db983ef94
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1317ac65b4f001588b86002aa22431719683beb4
Choose a head ref
  • 5 commits
  • 18 files changed
  • 1 contributor

Commits on Nov 19, 2019

  1. src: introduce custom smart pointers for BaseObjects 

    Referring to `BaseObject` instances using standard C++ smart pointers
can interfere with BaseObject’s own cleanup mechanisms
(explicit delete, delete-on-GC and delete-on-cleanup).

Introducing custom smart pointers allows referring to `BaseObject`s
safely while keeping those mechanisms intact.

Refs: nodejs/quic#141
Refs: nodejs/quic#149
Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #30374
Refs: nodejs/quic#165
Reviewed-By: David Carlier <devnexen@gmail.com>
    @addaleax
    addaleax committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    7e6104f View commit details
    Browse the repository at this point in the history

  2. http2: use custom BaseObject smart pointers 

    Refs: nodejs/quic#141
Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #30374
Refs: nodejs/quic#149
Refs: nodejs/quic#165
Reviewed-By: David Carlier <devnexen@gmail.com>
    @addaleax
    addaleax committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    a36f220 View commit details
    Browse the repository at this point in the history

  3. src: use BaseObjectPtr for keeping channel alive in dns bindings 

    PR-URL: #30374
Refs: nodejs/quic#141
Refs: nodejs/quic#149
Refs: nodejs/quic#141
Refs: nodejs/quic#165
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
    @addaleax
    addaleax committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    c0b5e6f View commit details
    Browse the repository at this point in the history

  4. src: remove keep alive option from SetImmediate() 

    This is no longer necessary now that the copyable `BaseObjectPtr`
is available (as opposed to the only-movable `v8::Global`).

PR-URL: #30374
Refs: nodejs/quic#141
Refs: nodejs/quic#149
Refs: nodejs/quic#141
Refs: nodejs/quic#165
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
    @addaleax
    addaleax committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    a489583 View commit details
    Browse the repository at this point in the history

  5. src: remove HandleWrap instances from list once closed 

    This allows keeping `BaseObjectPtr`s to `HandleWrap` instances.
Previously, the pointer kept the `HandleWrap` object alive, leaving
the Environment cleanup code that waits for the handle list to drain
in a busy loop, because only the `HandleWrap` destructor removed
the item from the list.

Refs: nodejs/quic#165
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

PR-URL: #30374
Refs: nodejs/quic#141
Refs: nodejs/quic#149
Refs: nodejs/quic#141
Reviewed-By: David Carlier <devnexen@gmail.com>
    @addaleax
    addaleax committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    1317ac6 View commit details
    Browse the repository at this point in the history
Loading