Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: eee522ac29864a55a8bc6686e6b38e93270aa1ca
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4cfa5dfccd492ff1da0bb88b38bd3887a01c5188
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Oct 11, 2020

  1. fs: use validateBoolean() in rm/rmdir validation 

    PR-URL: #35565
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
    @cjihrig @nodejs-github-bot
    cjihrig authored and nodejs-github-bot committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    0b31b9d View commit details
    Browse the repository at this point in the history

  2. fs: update rm/rmdir validation messages 

    The validation code for the rm/rmdir functions treated the
options as distinct parameters instead of the options properties
that they are. This commit updates the validation to treat them
like properties.

PR-URL: #35565
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
    @cjihrig @nodejs-github-bot
    cjihrig authored and nodejs-github-bot committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    4cfa5df View commit details
    Browse the repository at this point in the history
Loading